Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Check if User is allowed to create a class when pasting #691

Merged
merged 2 commits into from
Sep 20, 2024
Merged

[Bug]: Check if User is allowed to create a class when pasting #691

merged 2 commits into from
Sep 20, 2024

Conversation

kingjia90
Copy link
Contributor

Resolves #690

@kingjia90 kingjia90 mentioned this pull request Sep 16, 2024
Closed
@kingjia90 kingjia90 marked this pull request as ready for review September 19, 2024 10:11
@kingjia90 kingjia90 added this to the 1.5.5 milestone Sep 19, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 19, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kingjia90
Copy link
Contributor Author

kingjia90 commented Sep 19, 2024 •
edited
Loading

For documents, unfortunately is not applicable because it works on the permission of the document type (these "presets/boilerplate")
image
but once you created a document, it lose the info from which preset it was created and it could be overidden anyways.

image

@fashxp
Copy link
Member

fashxp commented Sep 19, 2024

For documents, unfortunately is not applicable because it works on the permission of the document type (these "presets/boilerplate")

Ahh, true ... Then just for data objects it is 👍

@robertSt7 robertSt7 self-assigned this Sep 20, 2024
@robertSt7 robertSt7 merged commit 8136685 into 1.5 Sep 20, 2024
10 of 11 checks passed
@robertSt7 robertSt7 deleted the fix-paste-create branch September 20, 2024 09:20
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@robertSt7 robertSt7

Labels
Bug Pimcore:ToDo
Projects
None yet
Milestone
1.5.5
Development

Successfully merging this pull request may close these issues.
3 participants
@kingjia90 @fashxp @robertSt7