Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Assets:upload zip archive-option to overwrite files #420

Conversation

opreacalina90
Copy link
Contributor

Here is an improvement for avoiding duplicates while uploading a zip with multiple files

Copy link

sonarcloud bot commented Feb 14, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@cancan101
Copy link
Contributor

What is the status of this pr?

I noticed that when uploading a folder (through drag and drop), pimcore just duplicates rather than asking if I want to overwrite.

@robertSt7
Copy link
Contributor

Hi @opreacalina90

I checked your PR and I see that you change some non-English translations files.
Actually only the update of the English translations have an effect, because these keys are then synced with POEditor. https://poeditor.com/join/project/XliCYYgILb
You can then translate it there to other languages.

Could you please remove all changes from the non-English files and fix the conflicts?

Thanks

Copy link

sonarcloud bot commented Sep 6, 2024

@robertSt7 robertSt7 merged commit 23664f8 into pimcore:1.x Sep 6, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2024
@robertSt7
Copy link
Contributor

@opreacalina90 Thanks a lot for the improvement

@robertSt7 robertSt7 added this to the 1.6.0 milestone Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants