You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there is a button in the toolbar to delete the whole folder
and there is the grid where you can select single items, right click and then click delete in the context menu to delete the selected items
In practice a lot of users accidentically remove the whole folder although they wanted to delete only some assets / objects. The reason is that they select some items in the grid with the checkboxes and then they click the Delete button in the toolbar. After confirming the deletion the whole folder is gone instead of the selected items.
With this PR, is some items are selected and the "Delete folder" button gets clicked, the same behaviour gets used as if the right-click contextmenu > Delete would have been used.
In other words: Only if no items are selected in the grid, the button will delete the whole folder.
I have read the CLA Document and I hereby sign the CLA
BlackbitDevs
changed the title
Added checking if assets/dataobjects checked inside folder grid then …
Prevent accidentical removal of whole folder instead of deleting single assets / objects
Jan 11, 2024
BlackbitDevs
changed the title
Prevent accidentical removal of whole folder instead of deleting single assets / objects
Prevent accidentical removal of whole folder instead of deleting selected assets / objects
Jan 11, 2024
@fashxp wdty? this change makes this delete button more flexible. The popup message should be also clear enough to implicitly explain this dual functionality.
Alternatively, we should split in 2 separated buttons (one folder+bin icon eg. combination of 📁❌ and one as delete selection that appears only there's any selection, plus a "clear selection" shortcut )
@kingjia90 I like the idea. We need to make sure though, that the delete button also works if grid not loaded yet - e.g. when grid-tab not opened for assets, or when class selection necessary in objects grid.
Thank you both for the changes and the reminder!
LGTM now, it would be just missing a CHANGELOG.md entry to announce this improvement, then we can merge it
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BlackbitDevs
changed the title
Theoretically the grid is easy:
In practice a lot of users accidentically remove the whole folder although they wanted to delete only some assets / objects. The reason is that they select some items in the grid with the checkboxes and then they click the Delete button in the toolbar. After confirming the deletion the whole folder is gone instead of the selected items.
With this PR, is some items are selected and the "Delete folder" button gets clicked, the same behaviour gets used as if the right-click contextmenu > Delete would have been used.
In other words: Only if no items are selected in the grid, the button will delete the whole folder.