New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move EventLoopTask into a separate file because it causes clangd to crash #13875

Merged

Jarred-Sumner merged 2 commits into main from jarred/event-loop-tasks

Sep 11, 2024

Collaborator

Jarred-Sumner commented Sep 11, 2024

What does this PR do?

Move EventLoopTask into a separate file because it causes clangd to crash according to the stacktrace

How did you verify your code works?


          Move EventLoopTask into a separate file because it causes clangd to c…

f648fd8

…rash

robobun commented Sep 11, 2024 •

edited

Loading

❌ @Jarred-Sumner, your commit 1c5d41a has 10 failures in #3276:

test/cli/watch/watch.test.ts - timeout on 🪟 x64

test/cli/watch/watch.test.ts - timeout on 🪟 x64-baseline

test/regression/issue/07500/07500.test.ts - 1 failing on 🪟 x64-baseline

test/cli/hot/watch.test.ts - 1 failing on 🪟 x64-baseline

test/cli/hot/watch.test.ts - 1 failing on 🪟 x64

test/cli/hot/hot.test.ts - 2 failing on 🪟 x64-baseline

test/cli/hot/hot.test.ts - 2 failing on 🪟 x64

test/js/bun/spawn/spawn-streaming-stdin.test.ts - 1 failing on 🪟 x64-baseline

test/js/bun/shell/leak.test.ts - 1 failing on 🪟 x64-baseline

test/js/web/streams/streams.test.js - 1 failing on 🍎 14 aarch64

test/js/web/streams/streams.test.js - 1 failing on 🍎 13 aarch64

test/js/web/streams/streams.test.js - 1 failing on 🍎 14 x64

test/bundler/bun-build-api.test.ts - 1 failing on 🪟 x64

test/bundler/bun-build-api.test.ts - 1 failing on 🪟 x64-baseline

test/js/bun/http/bun-serve-static.test.ts - 2 failing on 🍎 13 aarch64

test/cli/install/registry/bun-install-registry.test.ts - 1 failing on 🍎 14 aarch64

test/cli/install/registry/bun-install-registry.test.ts - 3 failing on 🪟 x64

test/cli/install/registry/bun-install-registry.test.ts - 4 failing on 🪟 x64-baseline

Contributor

github-actions bot commented Sep 11, 2024 •

edited

Loading

clang-tidy nits are fixed! Thank you.


          Fix buildissue

1c5d41a

Jarred-Sumner merged commit 97baeb8 into main

47 checks passed

Jarred-Sumner deleted the jarred/event-loop-tasks branch

September 11, 2024 07:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet