-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(node:net
, node:tls
) add named pipe support on node:net
and node:tls
modules
#13838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cirospaciari
force-pushed
the
ciro/named-pipe-net-tls
branch
from
September 10, 2024 15:53
b174010
to
e561fa7
Compare
cirospaciari
commented
Sep 10, 2024
@@ -1157,8 +1157,9 @@ pub fn WindowsStreamingWriter( | |||
this.source = null; | |||
if (this.closed_without_reporting) { | |||
this.closed_without_reporting = false; | |||
onClose(this.parent); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty sure that this can cause issues, lets see CI, my guess is streams and IPC
cirospaciari
force-pushed
the
ciro/named-pipe-net-tls
branch
from
September 12, 2024 00:39
f21fbe5
to
ed6cf40
Compare
@@ -2645,7 +2644,7 @@ pub fn translateUVErrorToE(code_in: anytype) bun.C.E { | |||
UV_EREMOTEIO => bun.C.E.REMOTEIO, | |||
UV_ECANCELED => bun.C.E.CANCELED, | |||
UV_ECHARSET => bun.C.E.CHARSET, | |||
UV_EOF => bun.C.E.OF, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
subtle
cirospaciari
force-pushed
the
ciro/named-pipe-net-tls
branch
from
September 12, 2024 18:38
fb2738b
to
3242954
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #13824
Fix: #11759
Fix: #13042
TODO
node:tls
to TLSWhat does this PR do?
How did you verify your code works?
Tests