Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node:net, node:tls) add named pipe support on node:net and node:tls modules #13838

Merged
merged 24 commits into from
Sep 12, 2024

Conversation

cirospaciari
Copy link
Collaborator

@cirospaciari cirospaciari commented Sep 10, 2024

Fix: #13824
Fix: #11759
Fix: #13042

TODO

  • Connect using libuv fd
  • Connect using system fd
  • Connect using path to named pipe
  • Client TLS
  • Listen path to named pipe
  • Server TLS
  • upgradeTLS (disabled only available when using JS Wrapper)
  • Upgrade via node:tls to TLS
  • Tests

What does this PR do?

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

Tests

@@ -1157,8 +1157,9 @@ pub fn WindowsStreamingWriter(
this.source = null;
if (this.closed_without_reporting) {
this.closed_without_reporting = false;
onClose(this.parent);
Copy link
Collaborator Author

@cirospaciari cirospaciari Sep 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty sure that this can cause issues, lets see CI, my guess is streams and IPC

@cirospaciari cirospaciari marked this pull request as ready for review September 12, 2024 00:38
@cirospaciari cirospaciari marked this pull request as draft September 12, 2024 00:45
@cirospaciari cirospaciari marked this pull request as ready for review September 12, 2024 01:54
@@ -2645,7 +2644,7 @@ pub fn translateUVErrorToE(code_in: anytype) bun.C.E {
UV_EREMOTEIO => bun.C.E.REMOTEIO,
UV_ECANCELED => bun.C.E.CANCELED,
UV_ECHARSET => bun.C.E.CHARSET,
UV_EOF => bun.C.E.OF,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subtle

@Jarred-Sumner Jarred-Sumner merged commit b1ca81a into main Sep 12, 2024
45 of 46 checks passed
@Jarred-Sumner Jarred-Sumner deleted the ciro/named-pipe-net-tls branch September 12, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants