Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: do not silently drop finalizer updates when status is also updated #1283

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

joelanford
Copy link
Member

This is a fix for a bug that @anik120 stumbled upon in catalogd while working on operator-framework/catalogd#379.

Wanted to fix it here as well while we're thinking about it.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@joelanford joelanford requested a review from a team as a code owner September 19, 2024 00:51
Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 6a60606
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66eb759dcfccf6000896e064
😎 Deploy Preview https://deploy-preview-1283--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joelanford joelanford changed the title fix: do not silently drop finalizer updates when status is also updated 🐛 fix: do not silently drop finalizer updates when status is also updated Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.51%. Comparing base (df0e848) to head (6a60606).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nternal/controllers/clusterextension_controller.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1283      +/-   ##
==========================================
+ Coverage   76.49%   76.51%   +0.01%     
==========================================
  Files          39       39              
  Lines        2361     2363       +2     
==========================================
+ Hits         1806     1808       +2     
  Misses        389      389              
  Partials      166      166              
Flag Coverage Δ
e2e 57.93% <50.00%> (+0.03%) ⬆️
unit 53.06% <50.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelanford
Copy link
Member Author

codecov/patch test seems to be failing because I moved the check for unexpected changes.

Copy link
Contributor

@anik120 anik120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codecov/patch test seems to be failing because I moved the check for unexpected changes.

Fwiw there were no tests added to confirm this was a problem before(which is fine coz we didn't know it was a problem), but there's no tests now to confirm on paper it is still not a problem

@tmshort
Copy link
Contributor

tmshort commented Sep 19, 2024

@anik120 not sure we want to test a panic, also not sure how to get a unit test to modify fields while we're in reconcile() This really is a "should never happen" type of situation during normal runs. It might panic if someone were making an incorrect code change.

Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2024
@anik120 anik120 dismissed their stale review September 19, 2024 14:13

Didn't realize it was a panic

@tmshort tmshort added this pull request to the merge queue Sep 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 19, 2024
@tmshort tmshort added this pull request to the merge queue Sep 19, 2024
Merged via the queue into operator-framework:main with commit 34821fa Sep 19, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants