Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopting-ish openZIM bootstrap #197

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Adopting-ish openZIM bootstrap #197

merged 2 commits into from
Sep 5, 2024

Conversation

rgaudin
Copy link
Member

@rgaudin rgaudin commented Sep 4, 2024

Getting closer to openZIM bootsrap (we build via setuptools for Cython extension)

Fixes #195

  • Upgraded build and dev dependencies
  • Removed setup.cfg (moved metadata to pyproject.toml)
  • Replaced isort and flake8 with bootstrap's ruff
  • Added config for pyright (disabled for now as libzim has no type hints)
  • bootstrap conf for lint/check/test
  • updated linting to match

This will be followed by a PR with type stubs

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.44%. Comparing base (a4ea3c2) to head (98499fe).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #197   +/-   ##
=======================================
  Coverage   93.44%   93.44%           
=======================================
  Files           1        1           
  Lines         519      519           
=======================================
  Hits          485      485           
  Misses         34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rgaudin rgaudin marked this pull request as ready for review September 4, 2024 15:57
Copy link

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see my comments before merging (minor)

README.md Outdated Show resolved Hide resolved
Getting closer to openZIM bootsrap (we build via setuptools for Cython extension)

Fixes #195

- Upgraded build and dev dependencies
- Removed setup.cfg (moved metadata to pyproject.toml)
- Replaced isort and flake8 with bootstrap's ruff
- Added config for pyright (disabled for now as libzim has no type hints)
- bootstrap conf for lint/check/test
- /!\ using PROFILE by default to have coverage tracing
- updated linting to match
@rgaudin rgaudin merged commit dee26e4 into main Sep 5, 2024
20 checks passed
@rgaudin rgaudin deleted the deps branch September 5, 2024 08:58
@rgaudin rgaudin self-assigned this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swicth to bootstrap-like
2 participants