Add Windows Support #196
Merged
Add Windows Support #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- self.arch to use lowercase as we expect cibuildwheel to pass amd64 while platform.machine() returns AMD64 on windows - Added Windows and amd64 as supported (list check) - Added archive suffix and archive format to support ZIP archive - Custom rename of arch in filename as openZIM uses x86_64 - Copying dll from bin/ folder (tree is different) and .lib file (not sure if needed) - Cleaning dll/lib as well - Setting to the exact nightly date we have it for (not targetting lastest nightly as it requires addtional ZIP handling TBD) - forcing cibuildwheel to only do windows py312 on amd64 for tests speed - forcing those wheels on windows branch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #196 +/- ##
=======================================
Coverage 93.44% 93.44%
=======================================
Files 1 1
Lines 519 519
=======================================
Hits 485 485
Misses 34 34 ☔ View full report in Codecov by Sentry. |
Windows has no runtime_library path that's practical for us - require user to set PATH specificaly before running python - require user to use os.add_dll_directory() before `import python` - require user to load libzim DLL (via `ctypes.CDLL()`) in memory before `import python` - require us to change our API to use of of those trick before importing wrapper Most practical solution found was thus to install our companion DLLs (libzim and libicu) next to the wrapper one. This is done via a new command that edits the built wheel Added conditional support for _DEBUG as this is required to link against debug libzim DLLs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Windows x64 support via libzim 9.2.3-2
Fixed #191
Fixed #91