Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lib): Adds abac based KAO configuration #349

Merged
merged 2 commits into from
Sep 19, 2024
Merged

feat(lib): Adds abac based KAO configuration #349

merged 2 commits into from
Sep 19, 2024

Conversation

dmihalcik-virtru
Copy link
Member

@dmihalcik-virtru dmihalcik-virtru commented Sep 10, 2024 •
edited
Loading

  • Adds a new parameter to the encrypt method, attributeValues, which takes the output of the GetAttributeValuesByFqns gRPC call as its input.
  • This will be followed by a more complete solution which also performs the RPC call if required: feat(lib): Load abac config from policy service #351

@dmihalcik-virtru dmihalcik-virtru marked this pull request as ready for review September 11, 2024 14:09
@dmihalcik-virtru dmihalcik-virtru requested a review from a team as a code owner September 11, 2024 14:09
@dmihalcik-virtru dmihalcik-virtru changed the title feat(lib): Adds abac based KAO configuration WIP feat(lib): Adds abac based KAO configuration Sep 11, 2024
pflynn-virtru
pflynn-virtru previously approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@pflynn-virtru pflynn-virtru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks fine. needs a split key expert to review

@dmihalcik-virtru dmihalcik-virtru mentioned this pull request Sep 17, 2024
Merged
elizabethhealy
elizabethhealy previously approved these changes Sep 17, 2024
View reviewed changes
lib/src/policy/granter.ts Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
72.5% Coverage on New Code (required ≥ 80%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@dmihalcik-virtru dmihalcik-virtru merged commit 6eb70c1 into main Sep 19, 2024
11 of 12 checks passed
@dmihalcik-virtru dmihalcik-virtru deleted the feature/abac-config branch September 19, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elizabethhealy elizabethhealy elizabethhealy approved these changes

@pflynn-virtru pflynn-virtru pflynn-virtru left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmihalcik-virtru @elizabethhealy @pflynn-virtru