Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API-1835: fix resync of operator informers #695

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

API-1835: fix resync of operator informers #695

wants to merge 1 commit into from

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Sep 16, 2024

No description provided.

@openshift-ci openshift-ci bot requested review from ibihim and liouk September 16, 2024 15:59
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2024
@deads2k deads2k changed the title fix resync of operator informers API-1835: fix resync of operator informers Sep 16, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 16, 2024 •
edited by openshift-ci bot
Loading

@deads2k: This pull request references API-1835 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 16, 2024
@deads2k
Copy link
Contributor Author

deads2k commented Sep 16, 2024

/retest

liouk
liouk reviewed Sep 17, 2024
View reviewed changes
pkg/operator/starter.go Outdated
@@ -138,8 +138,9 @@ func RunOperator(ctx context.Context, controllerContext *controllercmd.Controlle
libgoetcd.EtcdEndpointNamespace,
)

// short resync period as this drives the check frequency when checking the .well-known endpoint. 20 min is too slow for that.
operatorConfigInformers := operatorinformer.NewSharedInformerFactory(authOperatorClient, time.Second*30)
// reyncs in individual controller loops for this operator are driven by a duration based trigger independent of a resource resync.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: typo

Suggested change
// reyncs in individual controller loops for this operator are driven by a duration based trigger independent of a resource resync.
// resyncs in individual controller loops for this operator are driven by a duration based trigger independent of a resource resync.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 18, 2024
@liouk
Copy link
Member

liouk commented Sep 20, 2024

/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2024
@liouk
Copy link
Member

liouk commented Sep 20, 2024

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, liouk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 23, 2024

New changes are detected. LGTM label has been removed.

@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1cc5528 and 2 for PR HEAD a431ef3 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 23, 2024

@deads2k: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-upgrade a431ef3 link true /test e2e-agnostic-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liouk liouk liouk left review comments

@ibihim ibihim Awaiting requested review from ibihim

Assignees

@liouk liouk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deads2k @openshift-ci-robot @liouk @openshift-merge-robot