UIFR-221 - UI Framework Session contains invalidated http session (#74)

openmrs · Feb 15, 2023 · c9a7166 · c9a7166
1 parent 8bfdbf6
commit c9a7166
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/api/src/main/java/org/openmrs/ui/framework/session/Session.java b/api/src/main/java/org/openmrs/ui/framework/session/Session.java
@@ -55,4 +55,7 @@ public <T> T getAttribute(String name, Class<T> asType) {
 		return (T) httpSession.getAttribute(name);
 	}
 
+	public void setHttpSession(HttpSession httpSession) {
+		this.httpSession = httpSession;
+	}
 }
diff --git a/api/src/main/java/org/openmrs/ui/framework/session/SessionFactory.java b/api/src/main/java/org/openmrs/ui/framework/session/SessionFactory.java
@@ -47,6 +47,7 @@ public Session ensureSession(HttpSession httpSession) {
 					}
 				}
 			}
+			session.setHttpSession(httpSession);
 			return session;
 		}
 	}
@@ -70,10 +71,12 @@ public Session getSession(HttpSession httpSession) {
 			ret = null;
 		}
 
-		if (ret != null)
+		if (ret != null) {
+			ret.setHttpSession(httpSession);
 			return ret;
-		else
+		} else {
 			return ensureSession(httpSession);
+		}
 	}
 
 	/**