Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #2895

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update README.md #2895

wants to merge 1 commit into from

Conversation

fmahdisoltani
Copy link

Motivation

The command to run the create_data.py script, does not run in shell.

Modification

Proper arguments should be passed to the script.

@CLAassistant
Copy link

CLAassistant commented Jan 27, 2024

CLA assistant check
All committers have signed the CLA.

@@ -11,7 +11,7 @@ We follow the procedure in [votenet](https://github.com/facebookresearch/votenet
4. Enter the project root directory, generate training data by running

```bash
python tools/create_data.py scannet --root-path ./data/scannet --out-dir ./data/scannet --extra-tag scannet
python tools/create_data.py --dataset scannet --root-path ./data/scannet --out-dir ./data/scannet --extra-tag scannet
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we do not need to add --dataset argument.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how you run this script, but on my end, when I run the script without the --dataset argument ( for scannet for example), I get the following error:

usage: create_data.py [-h] [--dataset kitti] [--root-path ROOT_PATH] [--version VERSION] [--max-sweeps MAX_SWEEPS] --out-dir OUT_DIR [--extra-tag EXTRA_TAG]
                      [--workers WORKERS]
create_data.py: error: unrecognized arguments: scannet

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this line makes the script expecting the --dataset argument.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am using python 3.10 btw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants