Remove the potential multiple managedclusterconfiguration support. #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @qiujian16 |
Signed-off-by: GitHub <noreply@github.com>
xuezhaojun
force-pushed
the
remove-the-potenial-multiple-managedclusterconfiguration-support
branch
from
98615cd
to
2276fd9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
==========================================
- Coverage 23.80% 23.34% -0.46%
==========================================
Files 9 9
Lines 1021 1015 -6
==========================================
- Hits 243 237 -6
Misses 759 759
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, xuezhaojun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 73d87ec
into
open-cluster-management-io:main
9 checks passed
xuezhaojun
deleted the
remove-the-potenial-multiple-managedclusterconfiguration-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constant managedclusterconfiguration is embed in the chart: https://github.com/open-cluster-management-io/cluster-proxy/blob/main/charts/cluster-proxy/templates/managedproxyconfiguration.yaml
Since we're not going to support multiple managedclusterconfiguration, clean this part of logic to simplify the code.