Merge pull request #211 from onebeyond/fix-dependent-question-for-mul…

…tiple-checkboxes Fix/Shows dependent questions of multiple_checkboxes fields
onebeyond · Mar 12, 2024 · 98dfeb6 · 98dfeb6
2 parents a08bd75 + 787b6c0
commit 98dfeb6
Show file tree

Hide file tree

Showing 7 changed files with 376 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
diff --git a/example/package-lock.json b/example/package-lock.json
diff --git a/example/src/forms/Contact/forms.json b/example/src/forms/Contact/forms.json
@@ -187,7 +187,25 @@
               "disableOthers": true
             }
           ]
-        }
+        },
+        "dependentQuestions": [
+          {
+            "condition": "others",
+            "question": {
+              "name": "test",
+              "type": "input",
+              "label": "Confirm password",
+              "placeholder": "Confirm password",
+              "errorMessages": {
+                "required": "This field is required",
+                "doesNotMatch": "The passwords do not match"
+              },
+              "registerConfig": {
+                "required": true
+              }
+            }
+          }
+        ]
       },
       {
         "name": "age",

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@onebeyond/react-form-builder",
-  "version": "1.5.0",
+  "version": "1.5.1",
   "description": "React from builder using json schema",
   "author": "One Beyond",
   "license": "MIT",

diff --git a/src/Questions/MultipleCheckboxes/index.js b/src/Questions/MultipleCheckboxes/index.js
@@ -26,12 +26,13 @@ const disableOthers = (e) => {
   })
 }
 
-const QuestionMultipleCheckboxes = ({ component, form, question, useForm }) => {
+const QuestionMultipleCheckboxes = ({ question, useForm }) => {
   const {
     formState: { errors },
     getValues,
     register
   } = useForm
+
   return (
     <div
       sx={{
@@ -70,7 +71,7 @@ const QuestionMultipleCheckboxes = ({ component, form, question, useForm }) => {
                     }}
                   >
                     <Checkbox
-                      data-testid='question-singleCheckbox'
+                      data-testid="question-singleCheckbox"
                       id={option.name}
                       aria-describedby={'error_message_' + question.name}
                       name={question.name}
@@ -80,6 +81,7 @@ const QuestionMultipleCheckboxes = ({ component, form, question, useForm }) => {
                       )}
                       {...register(question.name, {
                         ...question.registerConfig,
+                        onChange: option.disableOthers && disableOthers,
                         validate: {
                           minimumLen: question.registerConfig.minimumLen
                             ? () =>
@@ -95,7 +97,6 @@ const QuestionMultipleCheckboxes = ({ component, form, question, useForm }) => {
                             : () => true
                         }
                       })}
-                      onChange={option.disableOthers && disableOthers}
                     />
                     {option.src ? (
                       <img src={option.src} />

diff --git a/src/builder.js b/src/builder.js
@@ -213,7 +213,6 @@ const FormBuilder = ({
           <QuestionMultipleCheckboxes
             useForm={useFormObj}
             question={question}
-            form={form}
           />
           {question.dependentQuestions &&
             question.dependentQuestions.map(