Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libobs: Fix crop to bounds ABI break #10264

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

exeldro
Copy link
Contributor

@exeldro exeldro commented Feb 19, 2024

Description

Fix ABI break in obs_sceneitem_get_info and obs_sceneitem_set_info

Motivation and Context

Fixes #10261

How Has This Been Tested?

On windows 11 with Aitum Vertical 1.4.0

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@exeldro
Copy link
Contributor Author

exeldro commented Feb 20, 2024

the build failed because obs-websocket also needs an update like this: obsproject/obs-websocket#1203

@RytoEX RytoEX added this to the OBS Studio 30.1 milestone Feb 20, 2024
@RytoEX RytoEX requested a review from derrod February 20, 2024 18:44
@Lain-B
Copy link
Collaborator

Lain-B commented Feb 21, 2024

For the sake of fixing this issue while still keeping the build system going 'm going to make some manual modifications. Going to remove the deprecation and then add it later after websockets is updated (still before 30.1)

(Lain note: Splitting parent commit. This was probably unintentionally
not taken into account in the origin crop_to_bounds PR.)
@Lain-B Lain-B merged commit 806c72f into obsproject:master Feb 21, 2024
14 checks passed
@exeldro exeldro deleted the fix_crop_to_bounds branch February 21, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stack overrun when plugin uses obs_sceneitem_get_info with OBS 30.1
3 participants