Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version: 4.0.0 → 4.0.1 #66

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Conversation

aryabharat
Copy link
Contributor

Add URL type for convet_url function for stix 1.x

Reference issue: #65

@CLAassistant
Copy link

CLAassistant commented Jan 16, 2024

CLA assistant check
All committers have signed the CLA.

@rpiazza
Copy link
Contributor

rpiazza commented Feb 1, 2024

@aryabharat - please merge in the master branch. It should allow the "checks" pass

@aryabharat
Copy link
Contributor Author

@rpiazza I have update the branch.

@rpiazza
Copy link
Contributor

rpiazza commented Feb 2, 2024

There is a problem with the github actions - they are failing. I know what needs to be done, but I have to get the admin of the OASIS-OPEN repo to do it. Hopefully, we can get this done soon.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0541655) 73.40% compared to head (7613544) 73.41%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   73.40%   73.41%           
=======================================
  Files          13       13           
  Lines        3380     3381    +1     
=======================================
+ Hits         2481     2482    +1     
  Misses        899      899           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rpiazza
Copy link
Contributor

rpiazza commented Feb 16, 2024

Hi @aryabharat,

I think if you fix the pre-commit error below - I will be able to do the merge:

tox: pre-commit-check
pre-commit-check: commands[0]> pre-commit run --all-files

trim trailing whitespace.................................................Passed
check for merge conflicts................................................Passed
Check project styling....................................................Failed

  • hook id: flake8
  • exit code: 1

stix2slider/convert_pattern.py:818:1: E302 expected 2 blank lines, found 1

Sort python imports (shows diff).........................................Passed
Sort python imports (fixes files)........................................Passed

@rpiazza rpiazza merged commit 0e7bd45 into oasis-open:master Feb 19, 2024
5 of 6 checks passed
@rpiazza
Copy link
Contributor

rpiazza commented Feb 19, 2024

@aryabharat - nevermind - I will take care of it...

@aryabharat
Copy link
Contributor Author

@aryabharat - nevermind - I will take care of it...

Thanks @rpiazza

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants