Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2909: Set container title when defining the Folder type from Document Type Selection using Direct Transfer #5253

Conversation

gitofanindya
Copy link
Collaborator

@gitofanindya gitofanindya commented Sep 17, 2024

NXDRIVE-2909: Set container title when defining the Folder type from Document Type Selection using Direct Transfer

Summary by Sourcery

Enhance the Direct Transfer feature by setting the container title when defining the Folder type from Document Type Selection, and update the release notes to document this change.

Enhancements:

  • Set the container title when defining the Folder type from Document Type Selection using Direct Transfer.

Documentation:

  • Document the change for setting the container title in the Direct Transfer section of the release notes.

…Document Type Selection using Direct Transfer
Copy link
Contributor

sourcery-ai bot commented Sep 17, 2024

Reviewer's Guide by Sourcery

This pull request addresses NXDRIVE-2909 by modifying the Direct Transfer functionality to set the container title when defining the Folder type from Document Type Selection. The changes involve updating the properties structure in the upload method and adding a changelog entry.

File-Level Changes

Change Details Files
Update the properties structure in the upload method
  • Replace single-line properties assignment with a nested dictionary structure
  • Set 'dc:title' property to doc_pair.local_name
nxdrive/client/uploader/direct_transfer.py
Add changelog entry for NXDRIVE-2909
  • Include a brief description of the change in the Direct Transfer section
docs/changes/5.5.1.md

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @gitofanindya - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.09%. Comparing base (4878e47) to head (5035068).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5253      +/-   ##
==========================================
- Coverage   52.10%   52.09%   -0.01%     
==========================================
  Files          96       96              
  Lines       16087    16087              
==========================================
- Hits         8382     8381       -1     
- Misses       7705     7706       +1     
Flag Coverage Δ
functional 42.88% <ø> (ø)
integration 2.01% <ø> (ø)
unit 40.52% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gitofanindya gitofanindya merged commit f1e3173 into master Sep 18, 2024
21 checks passed
@gitofanindya gitofanindya deleted the wip-NXDRIVE-2909-set-container-title-when-defining-the-Folder-type-from-document-type-selection-using-direct-transfer branch September 18, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants