Upgraded python 3.9.5 to 3.12.3 #4850
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @gitofanindya - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
nxdrive/__main__.py
Outdated
| @@ -37,8 +37,8 @@ def main() -> int: | |||
|
|
|||
| try: | |||
| # XXX_PYTHON | |||
| if sys.version_info < (3, 9, 1): | |||
| raise RuntimeError(f"{APP_NAME} requires Python 3.9.1+") | |||
| if sys.version_info < (3, 12, 3): | |||
There was a problem hiding this comment.
suggestion (code_refinement): Check for potential breaking changes or deprecated features in Python 3.12.
Review the Python 3.12 release notes to ensure no deprecated features are being used that could affect the application's functionality.
| if sys.version_info < (3, 12, 3): | |
| import warnings | |
| if sys.version_info < (3, 12, 3): | |
| raise RuntimeError(f"{APP_NAME} requires Python 3.12.3+") | |
| else: | |
| # Check for deprecated Python features in 3.12 that may affect the application | |
| if sys.version_info[:2] == (3, 12): | |
| warnings.warn("Check Python 3.12 release notes for deprecated features.") |
| @@ -52,7 +52,7 @@ Executing the script without argument will setup.update the isolated environment | |||
|
|
|||
| [//]: # (XXX_PYTHON, XXX_INNO_SETUP) | |||
|
|
|||
| - [Python 3.9.5](https://www.python.org/ftp/python/3.9.5/python-3.9.5.exe). | |||
| - [Python 3.12.3](https://www.python.org/ftp/python/3.12.3/python-3.12.3.exe). | |||
There was a problem hiding this comment.
suggestion (code_clarification): Update documentation to reflect new Python version requirements.
Ensure all references in the documentation consistently reflect the upgrade to Python 3.12.3 to avoid confusion.
| - [Python 3.12.3](https://www.python.org/ftp/python/3.12.3/python-3.12.3.exe). | |
| [Python 3.12.3](https://www.python.org/downloads/release/python-3123/) |
gitofanindya
force-pushed
the
Upgrade-Python
branch
3 times, most recently
from
ec3aba7
to
c53a003
Compare
gitofanindya
force-pushed
the
Upgrade-Python
branch
from
c53a003
to
6e92012
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4850 +/- ##
==========================================
- Coverage 49.24% 48.62% -0.62%
==========================================
Files 94 95 +1
Lines 15699 16076 +377
==========================================
+ Hits 7731 7817 +86
- Misses 7968 8259 +291
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Upgraded python 3.9.5 to 3.12.3