Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Messageのテストをbytes配列を使ってテストするように修正 #81

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Messageのテストをbytes配列を使ってテストするように修正 #81

merged 3 commits into from
Sep 13, 2024

Conversation

yuki-uchida
Copy link
Collaborator

概要

  • Messageのテストで不足していたところを追加
  • packetize/depacketizeでbyte配列を使ってテストするように変更

該当issue

#22

tetter27
tetter27 requested changes Sep 11, 2024
View reviewed changes
moqt-core/src/modules/messages/announce.rs Show resolved Hide resolved
moqt-core/src/modules/messages/client_setup.rs Outdated Show resolved Hide resolved
moqt-core/src/modules/messages/client_setup.rs Outdated Show resolved Hide resolved
moqt-core/src/modules/messages/server_setup.rs Outdated Show resolved Hide resolved
moqt-core/src/modules/messages/server_setup.rs Outdated Show resolved Hide resolved
moqt-core/src/modules/messages/version_specific_parameters.rs Outdated Show resolved Hide resolved
@yuki-uchida yuki-uchida merged commit 890038b into master Sep 13, 2024
2 checks passed
@yuki-uchida yuki-uchida deleted the refactoring/core-message-test branch September 13, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tetter27 tetter27 tetter27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuki-uchida @tetter27