Org-wide linter #2943
Draft
Org-wide linter #2943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
End-rey
requested review from
roman-khimov,
carpawell and
cthulhu-rider
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2943 +/- ##
=======================================
Coverage 23.77% 23.78%
=======================================
Files 779 779
Lines 45995 45999 +4
=======================================
+ Hits 10936 10941 +5
+ Misses 34199 34198 -1
Partials 860 860 ☔ View full report in Codecov by Sentry. |
pkg/local_object_storage/blobstor/fstree/fstree_write_generic.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Open
Use: - `eacl.Target.RawSubjects` instead of `eacl.Target.BinaryKeys` - `eacl.NewTargetByRole` with `eacl.Target.SetRawSubjects` for targets with public keys - `eacl.ConstructTable` instead of `eacl.NewTable` - `eacl.ConstructRecord` instead of `eacl.NewRecord` - `*.Get*ID` instead of `*.*ID` - comparing with == instead of `ID.Equals` - `cid.NewFromMarshalledContainer(cnr.Marshal())` instead of `cid.ID.CalculateID` - `user.NewFromECDSAPublicKey` instead of `user.ResolveFromECDSAPublicKey` - direct copy instead of `ID.Encode` - direct assign instead of `ID.SetSHA256` Signed-off-by: Andrey Butusov <andrey@nspcc.io>
End-rey
force-pushed
the
2940-adapt-org-wide-linter
branch
from
7468c36
to
b721910
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2940.