fix/Panic in storagegroup put
#2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context was added in nspcc-dev#2135 but not initialized. Signed-off-by: Pavel Karpy <carpawell@morphbits.io>
Codecov Report
@@ Coverage Diff @@
## master #2399 +/- ##
==========================================
+ Coverage 30.03% 30.15% +0.11%
==========================================
Files 398 399 +1
Lines 29806 29868 +62
==========================================
+ Hits 8953 9006 +53
- Misses 20128 20132 +4
- Partials 725 730 +5
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
notimetoname
changed the title
storage-group putstoragegroup put
roman-khimov
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context was added in #2135 but not initialized.
BTW, another argument for nspcc-dev/neo-go#3026 (comment). I doubt it would have happened if the interface had been
Head(context.Context, oid.Address).Closes #2398.