native: implement HF-based update

Close #3213.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

pkg/compiler/native_test.go

@@ -288,7 +288,7 @@ func runNativeTestCases(t *testing.T, ctr interop.ContractMD, name string, nativ
 	})
 }
 
-func getMethod(t *testing.T, ctr interop.ContractMD, name string, params []string) interop.MethodAndPrice {
+func getMethod(t *testing.T, ctr interop.ContractMD, name string, params []string) interop.HFSpecificMethodAndPrice {
 	paramLen := len(params)
 
 	switch {
@@ -308,8 +308,10 @@ func getMethod(t *testing.T, ctr interop.ContractMD, name string, params []strin
 		name = strings.TrimSuffix(name, "WithData")
 	}
 
-	md, ok := ctr.GetMethod(name, paramLen)
-	require.True(t, ok, ctr.Manifest.Name, name, paramLen)
+	latestHF := config.LatestHardfork()
+	cMD := ctr.HFSpecificContractMD(&latestHF)
+	md, ok := cMD.GetMethod(name, paramLen)
+	require.True(t, ok, cMD.Manifest.Name, name, paramLen)
 	return md
 }
 

pkg/config/hardfork.go

@@ -36,9 +36,30 @@ func init() {
 	}
 }
 
+// Cmp returns the result of hardforks comparison. It returns:
+//
+//	-1 if hf <  other
+//	 0 if hf == other
+//	+1 if hf >  other
+func (hf Hardfork) Cmp(other Hardfork) int {
+	switch {
+	case hf == other:
+		return 0
+	case hf < other:
+		return -1
+	default:
+		return 1
+	}
+}
+
 // IsHardforkValid denotes whether the provided string represents a valid
 // Hardfork name.
 func IsHardforkValid(s string) bool {
 	_, ok := hardforks[s]
 	return ok
 }
+
+// LatestHardfork returns latest known hardfork.
+func LatestHardfork() Hardfork {
+	return hfLast >> 1
+}

pkg/core/blockchain.go

@@ -44,7 +44,7 @@ import (
 
 // Tuning parameters.
 const (
-	version = "0.2.10"
+	version = "0.2.11"
 
 	// DefaultInitialGAS is the default amount of GAS emitted to the standby validators
 	// multisignature account during native GAS contract initialization.
@@ -341,16 +341,37 @@ func (bc *Blockchain) GetDesignatedByRole(r noderoles.Role) (keys.PublicKeys, ui
 	return res, h, err
 }
 
+// getCurrentHF returns latest currently enabled hardfork. In case if no hardforks is enabled, the
+// default config.Hardfork(0) value is returned.
+func (bc *Blockchain) getCurrentHF() config.Hardfork {
+	var (
+		height  = bc.BlockHeight()
+		current config.Hardfork
+	)
+	// Rely on the fact that hardforks list is continuous.
+	for _, hf := range config.Hardforks {
+		enableHeight, ok := bc.config.Hardforks[hf.String()]
+		if !ok || height < enableHeight {
+			break
+		}
+		current = hf
+	}
+	return current
+}
+
 // SetOracle sets oracle module. It can safely be called on the running blockchain.
 // To unregister Oracle service use SetOracle(nil).
 func (bc *Blockchain) SetOracle(mod native.OracleService) {
+	// TODO: ensure Oracle script is updated when needed.
 	orc := bc.contracts.Oracle
+	currentHF := bc.getCurrentHF()
 	if mod != nil {
-		md, ok := orc.GetMethod(manifest.MethodVerify, -1)
+		orcMd := orc.HFSpecificContractMD(&currentHF)
+		md, ok := orcMd.GetMethod(manifest.MethodVerify, -1)
 		if !ok {
 			panic(fmt.Errorf("%s method not found", manifest.MethodVerify))
 		}
-		mod.UpdateNativeContract(orc.NEF.Script, orc.GetOracleResponseScript(),
+		mod.UpdateNativeContract(orcMd.NEF.Script, orc.GetOracleResponseScript(),
 			orc.Hash, md.MD.Offset)
 		keys, _, err := bc.GetDesignatedByRole(noderoles.Oracle)
 		if err != nil {
@@ -487,8 +508,10 @@ func (bc *Blockchain) init() error {
 	// Check autogenerated native contracts' manifests and NEFs against the stored ones.
 	// Need to be done after native Management cache initialization to be able to get
 	// contract state from DAO via high-level bc API.
+	var current = bc.getCurrentHF()
 	for _, c := range bc.contracts.Contracts {
 		md := c.Metadata()
+		hfMD := md.HFSpecificContractMD(&current)
 		storedCS := bc.GetContractState(md.Hash)
 		// Check that contract was deployed.
 		if !bc.isHardforkEnabled(c.ActiveIn(), bHeight) {
@@ -505,7 +528,7 @@ func (bc *Blockchain) init() error {
 			return fmt.Errorf("failed to check native %s state against autogenerated one: %w", md.Name, err)
 		}
 		autogenCS := &state.Contract{
-			ContractBase:  md.ContractBase,
+			ContractBase:  hfMD.ContractBase,
 			UpdateCounter: storedCS.UpdateCounter, // it can be restored only from the DB, so use the stored value.
 		}
 		autogenCSBytes, err := stackitem.SerializeConvertible(autogenCS)
@@ -2269,8 +2292,12 @@ func (bc *Blockchain) GetNativeContractScriptHash(name string) (util.Uint160, er
 // GetNatives returns list of native contracts.
 func (bc *Blockchain) GetNatives() []state.NativeContract {
 	res := make([]state.NativeContract, 0, len(bc.contracts.Contracts))
+	current := bc.getCurrentHF()
 	for _, c := range bc.contracts.Contracts {
-		res = append(res, c.Metadata().NativeContract)
+		md := c.Metadata().HFSpecificContractMD(&current)
+		res = append(res, state.NativeContract{
+			ContractBase: md.ContractBase,
+		})
 	}
 	return res
 }