Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrent js:serve runExecutor iterators failure #193

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cdaringe
Copy link

@cdaringe cdaringe commented Mar 12, 2022

Problem

  • executor foo tries to run and iterate through two js:serve executors on the dummy app, but only one app runs

Understanding the demo

  • A custom executor is authored, which does things concurrently
  • runExecutor is called twice, producing two async iterators
  • those iterators are combined, then all events attempted to be iterated through

...however, execution halts for one iterator.

You can swap the target (such as build, lint) and these targets do not suffer the failure

@@ -0,0 +1,7 @@
// eslint-disable-next-line no-eval
const argv = eval('process').argv as string[];
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just cause it's late and i got lazy configuring typescript for node :)

@netlify
Copy link

netlify bot commented Mar 12, 2022

✔️ Deploy Preview for nrwl-nx-examples-dep-graph ready!

🔨 Explore the source changes: 55fc9e9

🔍 Inspect the deploy log: https://app.netlify.com/sites/nrwl-nx-examples-dep-graph/deploys/622c54838bdd47000830a159

😎 Browse the preview: https://deploy-preview-193--nrwl-nx-examples-dep-graph.netlify.app

@@ -0,0 +1,32 @@
module.exports = async function* combine(iterable) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yanked from https://stackoverflow.com/a/50586391

just a copy-paste for combine AsyncIterators to exhaust them concurrently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant