change toLower to toLowerANSI #410
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh? Why? |
|
its faster than toLower because it only expects characters up to 255 https://community.bistudio.com/wiki/toLowerANSI
|
diwako
reviewed
Aug 25, 2024
| @@ -11,7 +11,7 @@ GVAR(CalloutCacheNamespace) = call CBA_fnc_createNamespace; | |||
| if !(".p3d" in _string) then { | |||
| _string = _string + ".p3d"; | |||
| }; | |||
| GVAR(blockSuppressionModelCache) setVariable [toLower _string, true]; | |||
| GVAR(blockSuppressionModelCache) setVariable [toLowerANSI _string, true]; | |||
There was a problem hiding this comment.
Here we probably should not do that, in case there is someone using none standard ANSI characters for the file path.
There was a problem hiding this comment.
As far as I remember, setVariable only supports ASCII characters as Variable names. So that should not be an issue
There was a problem hiding this comment.
private _yeet = false call CBA_fnc_createNamespace;
private _string = "\правда\model.p3d";
if ((_string select [0,1]) isEqualTo "\") then {
_string = [_string, 1] call CBA_fnc_substr;
};
if !(".p3d" in _string) then {
_string = _string + ".p3d";
};
_yeet setVariable [toLowerANSI _string, true];
allVariables _yeetreturns ["������������\model.p3d"]
There was a problem hiding this comment.
that means obfuscated pbos will not work well here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: