Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move repo to nixpkgs-24.05 #523

Merged
merged 12 commits into from
Jul 22, 2024
Merged

Conversation

catwith1hat
Copy link
Contributor

Here is a set of commits that moves the repo to nixpkgs-24.05.

  • ssvnode: It iss stuck on Go 1.20 because of its quic-go dependency.
  • mev--boost-prysm points to an archived GitHub repo, so I removed that package.
  • geth/erigon: Both surprisingly required new vendor hashes for their go modules. I presume that's because the Go compiler changed. But at the same time many other Go programs in this repo didn't require that. So I am a bit puzzled.
  • sedge/rotki-bin: Fails to compiled. Didn't look into it and I just pinned it to 23.11. Can be fixed later.

Feedback welcome.

@catwith1hat
Copy link
Contributor Author

I finally found, why nix flake check failed and fixed the underlying issue (the overlay definition commit).

@aldoborrero @selfuryon Could you give some feedback? Thanks!

@aldoborrero
Copy link
Collaborator

@catwith1hat apologies as these past few weeks I've been mostly out in terms of ethereum.nix, so apologies for the slowness, I'll have a look at the PR this weekend. Thanks for your patience :)

@catwith1hat
Copy link
Contributor Author

No rush. I just wanted to make sure that nobody else is working it :).

@catwith1hat
Copy link
Contributor Author

Maybe this could be looked at in the next few days? :) Thanks!

@cryptix cryptix mentioned this pull request Jul 14, 2024
1 task
@aldoborrero
Copy link
Collaborator

aldoborrero commented Jul 15, 2024

@catwith1hat again apologies with the delay. I executed nix flake check on this branch:

framework :: Dev/nix-community/ethereum.nix ‹bump2405› % nix flake check                                                                                                                                                                                                                                                                                                                   1 ↵
error: hash mismatch in fixed-output derivation '/nix/store/kdww16w2ql6x4qa8kp8c95cvvx97v4zp-erigon-2.60.0-go-modules.drv':
         specified: sha256-uOUnUvP0fhNYWSfICkqJV8aMI2f0017baP58VedPov4=
            got:    sha256-38NmSSK3a70WvhZAZ529wdAMlEuk8/4YqtadoLOn1IY=
error: 1 dependencies of derivation '/nix/store/pdhhw667xfnjyh3ypbx45s6imslpqbdl-erigon-2.60.0.drv' failed to build
error (ignored): error: cannot unlink '/tmp/nix-build-reth-0.2.0-beta.6.drv-1/build': Directory not empty
error (ignored): error: cannot unlink '/tmp/nix-build-nethermind-1.25.4.drv-1/build/tmp.cNaOSZoAQS/.nuget/packages': Directory not empty
error (ignored): error: cannot unlink '/tmp/nix-build-heimdall-0.7.3.drv-1/build/source/target/release/deps': Directory not empty
error (ignored): error: cannot unlink '/tmp/nix-build-foundry-nightly-0688b5a.drv-1/build/source/target/release/deps': Directory not empty
error (ignored): error: cannot unlink '/tmp/nix-build-builder-1.11.5-0.3.0.drv-1/build/go-cache': Directory not empty
error: build of '/nix/store/0vxps0k5h1gsq4f0vq8m96a7cwv1vhms-eth2-testnet-genesis-0.9.0.drv', '/nix/store/11a7fq4gy1sgmzhfigxh28h2sfqrj1yx-geth-1.14.3.drv', '/nix/store/7i3m3hzhq4brr9zc2h6gjc8ckc43lz33-lighthouse-5.1.3.drv', '/nix/store/82hmcx95hn0yzpgpx6f8apv4d0ggb5am-nimbus-eth2-24.6.0.drv', '/nix/store/b03iv5fmx4r8i47hjgbamdnpxgh0w6d2-mev-boost-relay-0.29.1.drv', '/nix/store/hs78pp4vgdfcs031rlx1yd63m701a4j0-dreamboat-0.4.20.drv', '/nix/store/i99i6l8gdmxn5gplxkcga4cjldh01795-nethermind-1.25.4.drv', '/nix/store/kywcacamv0nkxbvng6ly74nx3l8w5iis-mev-rs-0.3.0.drv', '/nix/store/kzck3n6jli97fpcdpjm3qjzdjh4ndfiv-reth-0.2.0-beta.6.drv', '/nix/store/lq995p78irkd5357dqdni79j7xg75k07-mev-boost-1.7.drv', '/nix/store/pdhhw667xfnjyh3ypbx45s6imslpqbdl-erigon-2.60.0.drv', '/nix/store/q5lsk8zkdyw295z3amrksk6p6fpvzdy5-heimdall-0.7.3.drv', '/nix/store/rvk6gqi2l3k9y0qrjm9nimdfpsasxd7y-builder-1.11.5-0.3.0.drv', '/nix/store/x0fnzr3cx330l70bnnm6py5hy76lhcb0-foundry-nightly-0688b5a.drv' failed

Maybe, some of the commits can be cherry-picked and incorporated into separate PRs and we can incorporate them faster whilst we're still solving all of the remaining issues:

@cryptix
Copy link

cryptix commented Jul 17, 2024

Trying to pull up ssvnode over here: ssvlabs/ssv#1478

@catwith1hat
Copy link
Contributor Author

Please retry. Somehow the updates break the hashes of erigon/geth.

When we bump nixpkgs to 24.05 some packages need to stay behind, as
they don't compile with 24.05.
nixpkgs-24.05, even when system = "x86_64-linux" will instantiate a
nixpkgs configuration for i686-linux. I believe that this is because
of the stdenv bootstrapping in <nixpkgs/pkgs/stdenv/linux/default.nix>
references an i686-linux version of glibc.

Because modules/testing.nix references the overlay definition, and
because of the bootstrapping logic above, we need to make the flake
overlay definition to handle unknown systems more gracefully. Return
an empty set, in case we don't know the system.
Copy link
Collaborator

@aldoborrero aldoborrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@catwith1hat thanks for taking the lead. LGTM.

@aldoborrero aldoborrero merged commit 5e1b6cd into nix-community:main Jul 22, 2024
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants