[Fixed] Fixed issue with group permissions not working if user is in …

…multiple groups fixes #9
nfourtythree · Jul 3, 2017 · 724cb3d · 724cb3d · admench · Jul 4, 2017
1 parent 045a894
commit 724cb3d
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/releases.json b/releases.json
@@ -1,4 +1,12 @@
 [
+    {
+        "version": "1.1.2",
+        "downloadUrl": "https://github.com/nfourtythree/SecureAssetDownload/archive/1.1.2.zip",
+        "date": "2017-07-03T09:10:00.111Z",
+        "notes": [
+            "[Fixed] Fixed issue with group permissions not working if user is in multiple groups"
+        ]
+    },
     {
         "version": "1.1.1",
         "downloadUrl": "https://github.com/nfourtythree/SecureAssetDownload/archive/1.1.1.zip",

diff --git a/secureassetdownload/SecureAssetDownloadPlugin.php b/secureassetdownload/SecureAssetDownloadPlugin.php
@@ -11,7 +11,7 @@ function getName()
 
   function getVersion()
   {
-    return '1.1.1';
+    return '1.1.2';
   }
 
   function getDeveloper()

diff --git a/secureassetdownload/services/SecureAssetDownloadService.php b/secureassetdownload/services/SecureAssetDownloadService.php
@@ -128,9 +128,15 @@ public function isDownloadAllowed(array $options = array())
         }
 
         $_returnGroupIdCheck = true;
+
         foreach ($usersGroupIds as $_groupId) {
           if (!$this->_checkInArray($_groupId, $options['userGroupId'])) {
             $_returnGroupIdCheck = false;
+          } else {
+            // If we find an applicable group jump out so true validation doesn't
+            // get overwritten
+            $_returnGroupIdCheck = true;
+            break;
           }
         }