Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update catch2 and fix Mac CI #31

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Update catch2 and fix Mac CI #31

merged 2 commits into from
Aug 21, 2024

Conversation

jwallwork23
Copy link
Contributor

@jwallwork23 jwallwork23 commented Aug 20, 2024 •
edited
Loading

Closes #29.

@jwallwork23 jwallwork23 added bug Something isn't working enhancement New feature or request labels Aug 20, 2024
@jwallwork23 jwallwork23 self-assigned this Aug 20, 2024
@jwallwork23 jwallwork23 force-pushed the issue29_update-catch2 branch 2 times, most recently from 7574610 to 88273a3 Compare August 20, 2024 12:32
@jwallwork23 jwallwork23 changed the title Update catch2 and use nextSIM-DG Docker build for CI Update catch2 and NetCDF and use nextSIM-DG Docker build for CI Aug 20, 2024
@jwallwork23 jwallwork23 changed the title Update catch2 and NetCDF and use nextSIM-DG Docker build for CI Update catch2 and NetCDF Aug 21, 2024
@jwallwork23
Copy link
Contributor Author

jwallwork23 commented Aug 21, 2024 •
edited
Loading

This was originally intended to also address #30 and #13 but it all became too complex. Let's just address the one issue for now and then come back to the others.

@jwallwork23 jwallwork23 changed the title Update catch2 and NetCDF Update catch2 and fix Mac CI Aug 21, 2024
@jwallwork23 jwallwork23 marked this pull request as ready for review August 21, 2024 12:38
TomMelt
TomMelt approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@TomMelt TomMelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jwallwork23 . Looks good to me.

@jwallwork23 jwallwork23 merged commit 12b1d60 into main Aug 21, 2024
2 checks passed
@jwallwork23 jwallwork23 deleted the issue29_update-catch2 branch August 21, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomMelt TomMelt TomMelt approved these changes

Assignees

@jwallwork23 jwallwork23

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to use catch2 version 3
2 participants
@jwallwork23 @TomMelt