fix to keep session

[mahibi]

WIP, will be improved.

when you were in a chat and received a call notification, then in onDetach of the chatview the session was removed by leaving the room. This fix will check if a call notification is ongoing and suppress to leave the room.

leaving the room in "onDetach" might cause more problems..(for example on first call when granting permissions?!)

TODO:

• check which issues might be related to the onDetach& leaveRoom handling

Signed-off-by: Marcel Hibbe dev@mhibbe.de

[nextcloud-android-bot]

Lint

Type	master	PR
Warnings	223	224
Errors	1	1

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	12
Correctness Warnings	121
Experimental Warnings	2
Internationalization Warnings	9
Malicious code vulnerability Warnings	168
Performance Warnings	29
Security Warnings	4
Dodgy code Warnings	214
Total	559

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	12
Correctness Warnings	121
Experimental Warnings	2
Internationalization Warnings	9
Malicious code vulnerability Warnings	168
Performance Warnings	29
Security Warnings	4
Dodgy code Warnings	214
Total	559

Lint increased!

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/1723-talk.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

[mahibi]

i think i was on the wrong track here.
While it would still make sense to keep the session for this case (might be improved), the true error seems to be #1725