Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Support for Voltronic Axpert P30 protocol inverters (main) #1407

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

minfrin
Copy link

@minfrin minfrin commented Apr 27, 2022

Adds support for the Voltronic Axpert inverters based on the P30 protocol.

Updated the nutdrv_qx driver to support the optional sending of commands
protected by CRC.

Initial support for query commands. Based on work done in the Voltronic
Sunny driver in https://github.com/nickma82/nut/tree/nutdrv_qx_voltronic-sunny_rebased+command

Still TODO:

Implement commands to write to the inverter.
Remove commented code originating from sunny driver.
Further testing.
Update docs (manpages, acknowledgements...)

Adds support for the Voltronic Axpert inverters based on the P30 protocol.

Updated the nutdrv_qx driver to support the optional sending of commands
protected by CRC.

Initial support for query commands. Based on work done in the Voltronic
Sunny driver in https://github.com/nickma82/nut/tree/nutdrv_qx_voltronic-sunny_rebased+command

Still TODO:

Implement commands to write to the inverter.
Remove commented code originating from sunny driver.
Further testing.
Update docs (manpages, acknowledgements...)
@lgtm-com
Copy link

lgtm-com bot commented Apr 27, 2022

This pull request introduces 1 alert when merging 5375524 into 9cb8de6 - view on LGTM.com

new alerts:

  • 1 for Comparison of narrow type with wide type in loop condition

@jimklimov jimklimov marked this pull request as draft August 10, 2022 16:32
@jimklimov
Copy link
Member

@minfrin : I marked the PR as draft for now, so it would not burden CI with failing code to build ephemeral merges as master branch marches on. Feel free to un-set draft mode when needed to test fixes to broken builds.

@minfrin
Copy link
Author

minfrin commented Aug 10, 2022

Thanks for this.

All the parameters being read are working well, and it's doing the job.

Testing the write functions is tricky, as the inverter is powering the machine it was developed on, so options are limited. Lining up a time to do safe testing.

@jimklimov
Copy link
Member

Cheers! Wondering if you have any updates on this? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants