Immediately return null when null is provided in content and location…

… providers
netgen-layouts · Sep 6, 2023 · c50751c · c50751c
1 parent 659d352
commit c50751c
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 0 deletions.
diff --git a/lib/Parameters/ValueObjectProvider/ContentProvider.php b/lib/Parameters/ValueObjectProvider/ContentProvider.php
@@ -24,6 +24,10 @@ public function __construct(Repository $repository, ErrorHandlerInterface $error
 
     public function getValueObject($value): ?Content
     {
+        if ($value === null) {
+            return null;
+        }
+
         try {
             /** @var \eZ\Publish\API\Repository\Values\Content\Content $content */
             $content = $this->repository->sudo(

diff --git a/lib/Parameters/ValueObjectProvider/LocationProvider.php b/lib/Parameters/ValueObjectProvider/LocationProvider.php
@@ -24,6 +24,10 @@ public function __construct(Repository $repository, ErrorHandlerInterface $error
 
     public function getValueObject($value): ?Location
     {
+        if ($value === null) {
+            return null;
+        }
+
         try {
             return $this->repository->sudo(
                 static fn (Repository $repository): Location => $repository->getLocationService()->loadLocation((int) $value),

diff --git a/tests/lib/Parameters/ValueObjectProvider/ContentProviderTest.php b/tests/lib/Parameters/ValueObjectProvider/ContentProviderTest.php
@@ -69,6 +69,18 @@ public function testGetValueObject(): void
         self::assertSame($content, $this->valueObjectProvider->getValueObject(42));
     }
 
+    /**
+     * @covers \Netgen\Layouts\Ez\Parameters\ValueObjectProvider\ContentProvider::getValueObject
+     */
+    public function testGetValueObjectWithNullValue(): void
+    {
+        $this->contentServiceMock
+            ->expects(self::never())
+            ->method('loadContent');
+
+        self::assertNull($this->valueObjectProvider->getValueObject(null));
+    }
+
     /**
      * @covers \Netgen\Layouts\Ez\Parameters\ValueObjectProvider\ContentProvider::getValueObject
      */

diff --git a/tests/lib/Parameters/ValueObjectProvider/LocationProviderTest.php b/tests/lib/Parameters/ValueObjectProvider/LocationProviderTest.php
@@ -59,6 +59,18 @@ public function testGetValueObject(): void
         self::assertSame($location, $this->valueObjectProvider->getValueObject(42));
     }
 
+    /**
+     * @covers \Netgen\Layouts\Ez\Parameters\ValueObjectProvider\LocationProvider::getValueObject
+     */
+    public function testGetValueObjectWithNullValue(): void
+    {
+        $this->locationServiceMock
+            ->expects(self::never())
+            ->method('loadLocation');
+
+        self::assertNull($this->valueObjectProvider->getValueObject(null));
+    }
+
     /**
      * @covers \Netgen\Layouts\Ez\Parameters\ValueObjectProvider\LocationProvider::getValueObject
      */