Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 704 #2176

Merged
merged 5 commits into from
Sep 10, 2024
Merged

Issue 704 #2176

merged 5 commits into from
Sep 10, 2024

Conversation

zmcNotafraid
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 0.71685% with 277 lines in your changes missing coverage. Please review.

Project coverage is 60.21%. Comparing base (f373f6b) to head (127e6e2).
Report is 499 commits behind head on develop.

Files with missing lines Patch % Lines
app/models/ckb_sync/transaction_parser.rb 0.00% 139 Missing ⚠️
app/models/ckb_sync/transactions.rb 0.00% 119 Missing ⚠️
app/workers/import_pending_tx_worker.rb 0.00% 13 Missing ⚠️
lib/websocket.rb 0.00% 6 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (f373f6b) and HEAD (127e6e2). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f373f6b) HEAD (127e6e2)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2176      +/-   ##
===========================================
- Coverage    67.56%   60.21%   -7.35%     
===========================================
  Files          289      355      +66     
  Lines         7944    10179    +2235     
===========================================
+ Hits          5367     6129     +762     
- Misses        2577     4050    +1473     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Miles Zhang <mingchang555@hotmail.com>
Signed-off-by: Miles Zhang <mingchang555@hotmail.com>
Signed-off-by: Miles Zhang <mingchang555@hotmail.com>
Signed-off-by: Miles Zhang <mingchang555@hotmail.com>
@zmcNotafraid zmcNotafraid added this pull request to the merge queue Sep 10, 2024
Merged via the queue into nervosnetwork:develop with commit 6fd6ff2 Sep 10, 2024
1 check passed
@zmcNotafraid zmcNotafraid deleted the issue-704 branch September 10, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants