Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adjust the date parameter to a timestamp #1394

Merged

Conversation

rabbitz
Copy link
Collaborator

@rabbitz rabbitz commented Aug 21, 2023

Because the page displays the local time, the database comparison is utc, so the time zone conversion is performed directly on the front end.

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2023

Codecov Report

Patch coverage: 64.39% and project coverage change: +0.81% 🎉

Comparison is base (bb447e4) 66.37% compared to head (78eb5d0) 67.19%.
Report is 30 commits behind head on develop.

❗ Current head 78eb5d0 differs from pull request most recent head d4eacfe. Consider uploading reports for the commit d4eacfe to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1394      +/-   ##
===========================================
+ Coverage    66.37%   67.19%   +0.81%     
===========================================
  Files          275      277       +2     
  Lines         7397     7414      +17     
===========================================
+ Hits          4910     4982      +72     
+ Misses        2487     2432      -55     
Files Changed Coverage Δ
...trollers/api/v1/address_transactions_controller.rb 95.55% <ø> (-0.10%) ⬇️
app/controllers/api/v1/blocks_controller.rb 95.34% <ø> (-0.11%) ⬇️
app/models/cell_input.rb 61.36% <ø> (ø)
app/models/deployed_cell.rb 56.57% <ø> (ø)
app/models/epoch_statistic.rb 100.00% <ø> (ø)
app/models/udt.rb 100.00% <ø> (ø)
app/services/charts/daily_statistic_generator.rb 96.55% <0.00%> (-3.45%) ⬇️
app/workers/pool_transaction_check_worker.rb 55.55% <ø> (ø)
lib/scheduler.rb 0.00% <0.00%> (ø)
lib/websocket.rb 0.00% <0.00%> (ø)
... and 8 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rabbitz rabbitz added this pull request to the merge queue Aug 21, 2023
Merged via the queue into nervosnetwork:develop with commit 55652eb Aug 21, 2023
1 check passed
@rabbitz rabbitz deleted the perf/export_transactions_as_csv branch August 21, 2023 07:14
zmcNotafraid pushed a commit to zmcNotafraid/ckb-explorer that referenced this pull request Aug 29, 2023
* chore: adjust the date parameter to a timestamp

* chore: adjust tests

* chore: update balance change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants