Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update notary branch #2771

Closed
wants to merge 176 commits into from
Closed

Update notary branch #2771

wants to merge 176 commits into from

Conversation

ZhangTao1596
Copy link
Contributor

No description provided.

ixje and others added 30 commits March 20, 2022 19:50
@ixje
Remove deprecated note (#2677)
2a64c1c
@erikzhang @shargon @Jim8y
3.2.0 (#2682)
41055be 
* Add ToJson overload (#2671)

* Add ToJson overload

* change

* Update src/neo/VM/Helper.cs

* Update src/neo/VM/Helper.cs

* Update src/neo/VM/Helper.cs

* Update src/neo/VM/Helper.cs

Co-authored-by: Jinghui Liao <jinghui@wayne.edu>

* Update src/neo/VM/Helper.cs

Co-authored-by: Jinghui Liao <jinghui@wayne.edu>

Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Jinghui Liao <jinghui@wayne.edu>

* Fix oom (#2665)

* Fix oom

* Revert reorder

* parameters order

Co-authored-by: Erik Zhang <erik@neo.org>

* Optimize inventory (#2659)

* add `murmur32` to crypto lib (#2604)

* 3.2.0

* fix

Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Jinghui Liao <jinghui@wayne.edu>
@erikzhang
3.2.1 (#2694)
ed68274 
* Devhawk/getAddressVersion2 (#2689)

* Fix fee in NativeContract.Invoke (#2692)

* GetTransaction signers (#2685)

* Allow the committee to block a member from the committee (#2695)
@shargon @erikzhang
Fix UpdateCounter issues (#2697)
6c09dc0 
* Fix

* Fix

* private

* Check policy during deploy

Co-authored-by: Erik Zhang <erik@neo.org>
@shargon
Update LedgerContract.cs (#2703)
d76b800
@shargon
Fix committe issue (#2707)
17656ce
@erikzhang
Fix Signer.ToStackItem() (#2711)
42b6480
@shargon @erikzhang
Fix GetCandidates (#2686)
9c4aad3 
* Fix GetCandidates

* Fix summary

* Add overload

* Iterator version

* Update KeyValueIterator.cs

* Update NeoToken.cs

* Delete KeyValueIterator.cs

* Add GetCandidatesInternal

* Optimize GetCandidateVote

* Fix fee

* Fix ComputeCommitteeMembers

* Fix UT

Co-authored-by: Erik Zhang <erik@neo.org>
@erikzhang
Fix fee of CreateMultisigAccount (#2712)
f09754c
@devhawk
NEP6Wallet.ToJson method (and tests) (#2714)
4128119
@Jim8y
Separate plugins in different folder (#2696)
3b1e4d8
@erikzhang
Sync NeoVM: add MODMUL and MODPOW (#2719)
6ec801d
@erikzhang
Fix native notify (#2731)
c9ff156
@erikzhang
Fix Iterators (#2730)
1fc7601
@erikzhang
Refactor wallet classes (#2726)
2e31a70
@erikzhang
Fix reference counting for native contracts (#2732)
251e4a1
@erikzhang
Fix native transfer (#2734)
5ce2ad8
@erikzhang
Add IDiagnostic interface (#2735)
f83720e
@erikzhang
Optimize storage (#2736)
56c952c
@erikzhang
Fix Blockchain.Persist (#2738)
979113a
@erikzhang
Snapshot isolation (#2729)
7153ce9
@erikzhang
Fix InteroperableList (#2740)
04e9cb7
@Hecate2
MakeTransaction takes optional arg block to run transactions in use…
f221221 
…r-defined blocks (#2739)

* MakeTransaction takes optional arg block to run with a virtual block

* rename block to persistingBlock
@doubiliu
Fix AES256Encrypt Bug in OSX (#2742)
03fd443
@erikzhang
Cache not found keys (#2744)
e7cc1fd
@shargon @erikzhang
Remove binary data from Signers (#2708)
9f383f8 
Co-authored-by: Erik Zhang <erik@neo.org>
@erikzhang
Modify fee of System.Runtime.GetNotifications (#2748)
eaa434d
@erikzhang
Optimize deserialization (#2737)
7800ad0 
Added a new `MemoryReader` class for deserialization. It significantly improves neo's performance by avoiding memory copies during deserializations.
@erikzhang
Fix dynamic call (#2745)
043682f
@erikzhang
Improve dynamic call (#2755)
44b95cc
Jim8y and others added 7 commits February 7, 2024 02:54
@Jim8y @superboyiii
@shargon @cschuchardt88 @NGDAdmin
[VM UT] update UT name (#3115)
d65c198 
* update UT name

* Update tests/Neo.VM.Tests/UT_StackItem.cs

Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>

* Update tests/Neo.VM.Tests/UT_StackItem.cs

Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>

* Update tests/Neo.VM.Tests/UT_StackItem.cs

Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>

* Update tests/Neo.VM.Tests/UT_StackItem.cs

Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>

* Update tests/Neo.VM.Tests/UT_StackItem.cs

Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>

* Update tests/Neo.VM.Tests/UT_ExecutionContext.cs

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

* Update tests/Neo.VM.Tests/UT_ScriptBuilder.cs

* Update tests/Neo.VM.Tests/UT_EvaluationStack.cs

* fix ut name

---------

Co-authored-by: Owen Zhang <38493437+superboyiii@users.noreply.github.com>
Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>
Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com>
@shargon
Related to #3082 (comment) (#3119)
e3707fd
@Jim8y @shargon
VM: avoid checking reference when the stack is not full. (#3107)
76c368e 
* avoid checking reference when the stack is not full.

* fix UT

* Add UT

---------

Co-authored-by: Fernando Diaz Toledano <shargon@gmail.com>
@Jim8y @shargon
[Neo VM: FIX] the GetString() methods of bytestring requires strictUT…
3e52756 
…F8 (#3110)

* the GetString() methods of bytestring requires strictUTF8, but we can set it differently.

* update UTF8 rule and add UT

* add comment and prefix to base64 string

* fix UT

* Rename ToString to Print and move it to the unit test where it is needed. As it is a test method and only unit test will need it.

* Update tests/Neo.VM.Tests/UtEvaluationStack.cs

* Update src/Neo.VM/Utility.cs

* Update tests/Neo.VM.Tests/UtEvaluationStack.cs

* move try string to vm test

* Centralize print

* fix UT

* fix base64 format

* Override ToString

* Clean using

---------

Co-authored-by: Shargon <shargon@gmail.com>
@Jim8y @shargon
[Neo Fix] fix the store crash issue (#3124)
95708b5 
* fix the store crash issue

* remove loadstore

* Clean changes

---------

Co-authored-by: Fernando Diaz Toledano <shargon@gmail.com>
@shargon
Fix storage encoding (#3130)
b4dadcb 
* Fix storage encoding

* Remove unsafe methods

* Revert BigEndian change

* Fix ut

* Revert change
@shargon
Allow access TestingEngine to internal (#3134)
4a5a7f5 
* Change to public StorageKey constructor

* cschuchardt88's feedback
@Jim8y Jim8y added the Need Active Pr will be closed after one week if no new activity. label Feb 12, 2024
cschuchardt88 and others added 17 commits February 14, 2024 01:22
@cschuchardt88 @Jim8y @shargon
Added publish to github packages (#3072)
25ed6d6 
* Added nuget packages source

* test

* Changed to windows

* fixed version

* fix

* fix nuget

* fixed nuget.config

* Fixed test

* Nuget fixes

* git

* working release

* Added cron job

* switch to keep 3 packages versions

* Update .github/workflows/main.yml

* Update .github/workflows/main.yml

Co-authored-by: Shargon <shargon@gmail.com>

* change secret

* change delete also

---------

Co-authored-by: Jimmy <jinghui@wayne.edu>
Co-authored-by: Shargon <shargon@gmail.com>
@shargon @Jim8y
Optimize opcode price charging (#3131)
4940501 
* Optimize price

* Jimmy's review

* CS0618

* Update tests/Neo.UnitTests/SmartContract/UT_OpCodePrices.cs

* Avoid Obsolete

---------

Co-authored-by: Jimmy <jinghui@wayne.edu>
@cschuchardt88 @shargon
Split namespaces into Different Libraries. (#3136)
6746665 
* INit

* Update

* Allow access internals

* Update `github` actions workflow.

* Add assmebly internals to test assemblies

* Added `null` checking in `ByteArrayComparer.cs`

* Updated unit test for ByteArrayComparer

* Fixed `ByteArrayComparer.Compare` double checking.

* Fixed iterate same `x`, `y` in `ByteArrayComparer.Compare`

* Fixed test error in `ByteArrayComparer.Compare`

* Fix redundant condition

---------

Co-authored-by: Fernando Diaz Toledano <shargon@gmail.com>
@Jim8y
add loadstore back (#3141)
fd3d68d
@shargon
Update InteropInterface (#3143)
3f002a6 
* Update InteropInterface

core-add-interop-check

* Update src/Neo.VM/Types/InteropInterface.cs

* Update Neo.VM.csproj
@shargon
Fix: Screen Rendering on Invalid Arguments (#3148)
ffa56fe 
* Fix #3135

* clean

* check base
@shargon
Update pkgs-delete.yml (#3150)
2e7e1e4 
* Update pkgs-delete.yml

* Update main.yml
@shargon
Update NuGet.Config (#3151)
a6803cf
@shargon
Fix package version and frameworks (#3152)
febcc21 
* Fix package version and frameworks

Credits to @Jim8y

* It seems that was already build
@shargon
Fix store (#3149)
ffa9064
@shargon
Decouple calculate fee from Wallet (#3147)
d8af2c6 
* Decouple calculate fee from Wallet

* clean iff

* Convert into extension

* Update src/Neo/Wallets/Helper.cs
@shargon @vncoelho
Fix coverage (#3155)
de39a36 
* Update main.yml

* Update main.yml

* Update main.yml

* Change format

* Update .github/workflows/main.yml

* Update main.yml

* Update .github/workflows/main.yml

* Update main.yml

* Update .github/workflows/main.yml

* Update main.yml

* Update .github/workflows/main.yml

* Update .github/workflows/main.yml

* Avoid add package in other os

* Update main.yml

* Update main.yml

* Final fix

* Update .github/workflows/main.yml

* Update main.yml

* Update main.yml

* Update .github/workflows/main.yml

* Update .github/workflows/main.yml

* Remove rm

In windows fail

---------

Co-authored-by: Vitor Nazário Coelho <vncoelho@gmail.com>
@shargon @Jim8y
@cschuchardt88 @vncoelho
VM - Jump table (#3120)
1fffb95 
* Jump table

* Types

* Splice

* revert partial

* More control

* Remove attribute

* ApplicationEngine logic

* Stack

* Bitwisee

* clean using

* Numeric

* Prepare

* AggressiveInlining

* one left

* Compound

* Slot

* Allow to override invalid opcode

* Specify jumpTable according to block

* Fix syscall

* Rename to UnloadContext

* Revert "Rename to UnloadContext"

This reverts commit 5a551da.

* Rename

* Update JumpTable.Control.cs

* Update src/Neo.VM/JumpTable/JumpTable.cs

* Rename methods

* Update src/Neo.VM/JumpTable/JumpTable.Push.cs

Co-authored-by: Jimmy <jinghui@wayne.edu>

* Update src/Neo.VM/ExecutionEngine.cs

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

* Update src/Neo.VM/ExecutionEngine.cs

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

* Update src/Neo.VM/ExecutionEngine.cs

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

* Update src/Neo/SmartContract/ApplicationEngine.cs

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

* use internal

* Allow previous constructor

* prevent new jumptTable if default

* Update src/Neo.VM/JumpTable/JumpTable.cs

---------

Co-authored-by: Jimmy <jinghui@wayne.edu>
Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>
Co-authored-by: Vitor Nazário Coelho <vncoelho@gmail.com>
@shargon @Jim8y
Allow Native Contracts to be updated (#2942)
b467613 
* Update manifest

* Fix comment

* Format & fix methods

* Fix new

* Initialize storage fixes

* Fix IsInitializeBlock

* Fix update

* Fix GetContractState

* Optimize

* Fix first invoke without sync

* Remove current methods

* Clean usings

* Improve reading Initialize

* Clean OnManifestCompose

* Use cache for all native contracts

* Fix ut

* Move cache to ApplicationEngine

* Clean code

* Allow nullable attribute

* Update src/Neo/SmartContract/Native/ContractEventAttribute.cs

* Add base call

* Fix one #2941 (comment)

* Fix IsInitializeBlock #2941 (comment)

* Add ContractEventAttribute constructors for ActiveIn

* Ensure ommited hfs

* Rename

* Case insensitive hf config

* Increase coverage

* More uts

* Rename

* Update src/Neo/SmartContract/Native/ContractManagement.cs

* format code

* Fix ProtocolSettings

* Update src/Neo/SmartContract/ApplicationEngine.cs

* format

* reorder using

* Fix UT

* Adding keccak256 (#2925)

* Create codeql.yml

* Keccak256

* Delete .github/workflows/codeql.yml

* Update src/Neo/SmartContract/Native/CryptoLib.cs

* add more keccak256 test cases as required

* Create codeql.yml

* Keccak256

* Delete .github/workflows/codeql.yml

* Update src/Neo/SmartContract/Native/CryptoLib.cs

* add more keccak256 test cases as required

* HF_Manticore

* Fix copyright

* Create codeql.yml

* Keccak256

* Delete .github/workflows/codeql.yml

* Update src/Neo/SmartContract/Native/CryptoLib.cs

* add more keccak256 test cases as required

* Create codeql.yml

* Keccak256

* Delete .github/workflows/codeql.yml

* Update src/Neo/SmartContract/Native/CryptoLib.cs

* add more keccak256 test cases as required

* HF_Manticore

* Fix copyright

* HF_Manticore

* Update CryptoLib.cs

* Update CryptoLib.cs

* Update UT_CryptoLib.cs

* Apply suggestions from code review

* clean usings

---------

Co-authored-by: Shargon <shargon@gmail.com>

* Fix net standard

* Add ut

* Fix update

* Fix update

---------

Co-authored-by: Jimmy <jinghui@wayne.edu>
@shargon
Allow to override sobre properties (#3159)
022a63e
@shargon
Expose GetContractState (#3161)
66ef246 
* Update NativeContract.cs

* Update MemoryStoreProvider.cs

* Update Neo.csproj
@vncoelho @Jim8y @shargon
BLS coverage result has a different name than the rest (#3162)
9373756 
* Update main.yml

close #3160

* the file does not exist on others matrix.os

* Update main.yml

* Update main.yml

* Update main.yml

* Update .github/workflows/main.yml

Co-authored-by: Shargon <shargon@gmail.com>

---------

Co-authored-by: Jimmy <jinghui@wayne.edu>
Co-authored-by: Shargon <shargon@gmail.com>
@vncoelho
Copy link
Member

@shargon, maybe this PR should be merged and open a new one from notory to master.

@shargon
Copy link
Member

shargon commented Feb 23, 2024

2022, I think that should be closed, and design notary in a different one (if someone are interested in)

@Jim8y
Copy link
Contributor

Jim8y commented Feb 24, 2024

Close this pr as inactive. Open only if you are going to maintain this pr.

@Jim8y Jim8y closed this Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Need Active Pr will be closed after one week if no new activity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.