Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update install instructions for caimanmanager #228

Merged
merged 8 commits into from
Oct 11, 2023
Merged

Update install instructions for caimanmanager #228

merged 8 commits into from
Oct 11, 2023

Conversation

rly
Copy link
Contributor

@rly rly commented Oct 9, 2023

Fix #227

@rly
Copy link
Contributor Author

rly commented Oct 9, 2023

The workflows also use caimanmanager.py install after a git clone of CaImAn. I'm not sure why that works and running caimanmanager.py install after a conda install of CaImAn doesn't.

@rly
Copy link
Contributor Author

rly commented Oct 9, 2023

Oh CaImAn 1.9.16 was released 5 days ago. The same errors are observed in
https://github.com/nel-lab/mesmerize-core/actions/runs/6428346009/job/17455374529?pr=226
https://github.com/nel-lab/mesmerize-core/actions/runs/6428346005/job/17455374662?pr=226

@rly rly mentioned this pull request Oct 9, 2023
Closed
kushalkolar
kushalkolar requested changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@kushalkolar kushalkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Mostly lgtm, few comments.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
rly and others added 3 commits October 9, 2023 09:48
@rly @kushalkolar
Update README.md
c236dbf 
Co-authored-by: Kushal Kolar <kushalkolar@gmail.com>
@rly @kushalkolar
Update README.md
4bc2031 
Co-authored-by: Kushal Kolar <kushalkolar@gmail.com>
@rly
Update README.md
65f4542
@kushalkolar kushalkolar merged commit 7c4cdc2 into nel-lab:master Oct 11, 2023
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushalkolar kushalkolar kushalkolar requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

caimanmanager step of installation instructions is incorrect on macOS
2 participants
@rly @kushalkolar