Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offset hint #430

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Offset hint #430

wants to merge 8 commits into from

Conversation

blackketter
Copy link

I took a crack at #359 with my first Swift code.
Screen Shot 2021-05-01 at 1 41 37 PM

@dexterleng
Copy link
Collaborator

Thanks for taking the time to implement this. This will dramatically reduce the no. of times users deactivate hint mode.

@dexterleng
Copy link
Collaborator

Hints at the bottom of the screen are not visible. I think a hintview that points downwards would be helpful.

Screenshot 2021-05-05 at 3 36 44 PM

@blackketter
Copy link
Author

Hints at the bottom of the screen are not visible. I think a hintview that points downwards would be helpful.

Screenshot 2021-05-05 at 3 36 44 PM

I'll work on that. And do the other edges as well, though that might take a little time.

@dexterleng
Copy link
Collaborator

And do the other edges as well, though that might take a little time.

Other edges as in left/right pointing hints? Up/Down should be enough right?

@blackketter
Copy link
Author

And do the other edges as well, though that might take a little time.

Other edges as in left/right pointing hints? Up/Down should be enough right?

Having left/right would make the hints more visible at the left and right edges of the screen. They could also be used in vertical columns of hints with the proper cluster detection.

@devnoname120
Copy link

@blackketter Is extra work needed to merge this PR?

@blackketter
Copy link
Author

I’m using it as is without problem, but dexter wanted some improvements. I suppose that would be his call, but I haven’t heard from him in a while.

@devnoname120
Copy link

@blackketter I'd suggest sending a friendly message to his email address. You can find it by running git log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants