Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change SERIAL_DEBUG into RF24NETWORK_DEBUG #228

Merged
merged 3 commits into from
Jun 15, 2024
Merged

Conversation

2bndy5
Copy link
Member

@2bndy5 2bndy5 commented Jun 15, 2024

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Click here for the full clang-format patch
diff --git a/RF24Network.cpp b/RF24Network.cpp
index 6cd1c28..42b549c 100644
--- a/RF24Network.cpp
+++ b/RF24Network.cpp
@@ -637,2 +637,2 @@ uint16_t ESBNetwork<radio_t>::read(RF24NetworkHeader& header, void* message, uin
-                                  "\n\r"),
-                             millis(), header.toString()));
+                                       "\n\r"),
+                                  millis(), header.toString()));

Have any feedback or feature suggestions? Share it here.

RF24Network.cpp Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot dismissed their stale review June 15, 2024 15:30

outdated suggestion

Copy link

Memory usage change @ bed8b9e

Board flash % RAM for global variables %
arduino:avr:nano 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrzero 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/helloworld_rx
flash
% examples/helloworld_rx
RAM for global variables
% examples/helloworld_rx_advanced
flash
% examples/helloworld_rx_advanced
RAM for global variables
% examples/helloworld_tx_advanced
flash
% examples/helloworld_tx_advanced
RAM for global variables
% examples/helloworld_tx
flash
% examples/helloworld_tx
RAM for global variables
% examples/Network_Priority_RX
flash
% examples/Network_Priority_RX
RAM for global variables
% examples/Network_Priority_TX
flash
% examples/Network_Priority_TX
RAM for global variables
%
arduino:avr:nano 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrzero 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV
Board,examples/helloworld_rx<br>flash,%,examples/helloworld_rx<br>RAM for global variables,%,examples/helloworld_rx_advanced<br>flash,%,examples/helloworld_rx_advanced<br>RAM for global variables,%,examples/helloworld_tx_advanced<br>flash,%,examples/helloworld_tx_advanced<br>RAM for global variables,%,examples/helloworld_tx<br>flash,%,examples/helloworld_tx<br>RAM for global variables,%,examples/Network_Priority_RX<br>flash,%,examples/Network_Priority_RX<br>RAM for global variables,%,examples/Network_Priority_TX<br>flash,%,examples/Network_Priority_TX<br>RAM for global variables,%
arduino:avr:nano,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrzero,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@2bndy5
Copy link
Member Author

2bndy5 commented Jun 15, 2024

Its a good thing you requested this change. I forgot that this lib was relying on RF24's IF_SERIAL_DEBUG definition.

@2bndy5 2bndy5 requested a review from TMRh20 June 15, 2024 22:02
@2bndy5 2bndy5 merged commit 219d055 into master Jun 15, 2024
97 checks passed
@2bndy5 2bndy5 deleted the change-debug-toggle-names branch June 15, 2024 23:43
@2bndy5
Copy link
Member Author

2bndy5 commented Jun 15, 2024

cherry picked to v1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants