Switch suggest component from UDL to proc-macros #6380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6380 +/- ##
=======================================
Coverage 52.72% 52.72%
=======================================
Files 125 125
Lines 12820 12820
=======================================
Hits 6759 6759
Misses 6061 6061 ☔ View full report in Codecov by Sentry. |
gruberb
commented
Sep 18, 2024
gruberb
force-pushed
the
disco-2917
branch
2 times, most recently
from
a085e47
to
84f7b04
Compare
gruberb
commented
Sep 19, 2024
megazords/ios-rust/MozillaTestServices/MozillaTestServices.xcodeproj/project.pbxproj
Show resolved
Hide resolved
bendk
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Looks great. To me this seems perfect, but we should wait for @linabutler to confirm that project.pbxproj change.
megazords/ios-rust/MozillaTestServices/MozillaTestServices.xcodeproj/project.pbxproj
Show resolved
Hide resolved
linabutler
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting the
suggest.udlfile and use proc-macros to export directly from the Rust codebase.