Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add asynchronous decentralized bayesian optimization #145

Open
wants to merge 40 commits into
base: main
Choose a base branch
from

Conversation

be-marc
Copy link
Sponsor Member

@be-marc be-marc commented Apr 29, 2024

No description provided.

@sumny
Copy link
Sponsor Member

sumny commented Jun 21, 2024

  • think about introducing async loop function that would allow OptmizerAdbo to behave similar as OptimizerMbo
  • If not moving forward with async loop function, maybe still allow OptimizerAdbo to be configured w.r.t surrogate and acquisition function optimizer.
  • Note that update logic w.r.t missing values was dropped in feat: bbotk async compatibility #146 and should be moved to OptimizerAdbo or async loop functions directly

@berndbischl
Copy link
Sponsor Member

  • the Surrogate learner code was already slightly underdocumented, the PR adds even more code here. It is not documented at all what this does. I think this is for imputing points which are currently under evaluation. I am not sure if we should mix that in.... at the very least this needs to be documented and commented

@berndbischl
Copy link
Sponsor Member

  • the SurrogateLearner is now tightly coupled with rush, and its imputation for async optim. I think this is not good design. Inherit from SL, create SLAsync. only do the impute there, don't touch the existing class.

  • we have to handle failed stated. but MBO should ALREADY cover that? just use the same mechanism.

  • we might slightly change the impute mechanism. we could a) sample between min/max b) instead of mean provide a "quantile value" which is constantly used (e.g. 0.5 would always use median). in any case, a reference should be provided?

@berndbischl
Copy link
Sponsor Member

  • make the interface of ADBO more "similar" to OptimizerMBO. the SL should be passable as a generic model.
  • there are quite a few option for eps decay. is that now also in general handable in MBO? we should pass in an ACQF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants