Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance Request Oxmaint (Independent Publisher) #3640

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

JRS-Connector
Copy link


When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)

If this is your first time submitting to GitHub and you need some help, please sign up for this session.

  • I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
  • I attest that the connector works and I verified by deploying and testing all the operations.
  • I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
  • I attest that I have added response schemas to my actions, unless the response schema is dynamic.
  • I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
  • If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

  • I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
  • Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
  • Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
  • If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

@JRS-Connector JRS-Connector requested a review from a team as a code owner September 5, 2024 22:07
@vmanoharas
Copy link
Contributor

Hello @JRS-Connector,

Kindly agree the CLA and follow below documents and submit your connector.

Settings.json and icon.png files are not required to submit.

https://learn.microsoft.com/en-us/connectors/custom-connectors/certification-submission-ip
https://github.com/microsoft/PowerPlatformConnectors/tree/dev/templates/Independent%20Publisher

@JRS-Connector
Copy link
Author

@microsoft-github-policy-service agree [company="Oxmaint Inc."]

@JRS-Connector
Copy link
Author

@microsoft-github-policy-service agree
@microsoft-github-policy-service agree company="Oxmaint Inc."

@vmanoharas
Copy link
Contributor

Hello @JRS-Connector,

Kindly agree the CLA and follow below documents and submit your connector.

Settings.json and icon.png files are not required to submit.

https://learn.microsoft.com/en-us/connectors/custom-connectors/certification-submission-ip https://github.com/microsoft/PowerPlatformConnectors/tree/dev/templates/Independent%20Publisher

Hi @JRS-Connector,

Kindly address above comments and re submit this PR.

@JRS-Connector JRS-Connector changed the title Adding Maintenance Request Oxmaint Maintenance Request Oxmaint (Independent Publisher) Sep 16, 2024
@JRS-Connector
Copy link
Author

JRS-Connector commented Sep 16, 2024

Hello @vmanoharas,
The changes have been addressed in the same PR. Do I have to create a new PR?

@vmanoharas
Copy link
Contributor

Hello @JRS-Connector,

Thank you for your reply, I can still see the settings.json and icon.png files in the artifacts, please see the screenshot below.

image

@JRS-Connector
Copy link
Author

JRS-Connector commented Sep 18, 2024

Hello @vmanoharas, Sorry about that! I have made the changes now. Could you please have a look?

Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @JRS-Connector

Kindly resolve review comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants