Skip to content

Commit

Permalink
Minor changes made to workflow file. (#35)
Browse files Browse the repository at this point in the history
* updated image name in docker compose file and added new job in maven workflow to start and stop app using docker compose

* updated maven workflow and created dependency between jobs

* removed needs from the job and added command to wait for localhost to be available after docker compose up

* updated steps for docker run in maven workflow file

* running only service and tests only using docker

* running only service and tests only using docker

* added 2 jobs, one to build service using node and run tests, another to build service using docker and run tests

* removed docker block from maven workflow, app will build and run tests using node
  • Loading branch information
mfaisalkhatri committed Sep 19, 2024
1 parent 39fd177 commit a307e02
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
1 change: 1 addition & 0 deletions .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ on:
- issue-*
jobs:
Build_App_using_node_and_Run_Tests:
name: Build Service using node and run unit tests

runs-on: ubuntu-latest
permissions:
Expand Down
8 changes: 2 additions & 6 deletions docker-compose-ecommerce.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@
# To stop the execution, hit Ctrl+C, and then `docker compose -f docker-compose-ecommerce.yml down`
services:
restful-ecommerce:
image: mfaisalkhatri/restful-ecommerce
image: mfaisalkhatri/restful-ecommerce-app
ports:
- 3004:3004
volumes:
- ./:/restful-ecommerce-app
extra_hosts:
- "host.docker.internal:host-gateway"
- 3004:3004

0 comments on commit a307e02

Please sign in to comment.