-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grothendieck forgetful functor #37
Conversation
Code looks good. Some thoughts on naming. I would call it some variation "first projection" rather than "forgetful" as I think of these Grothendieck constructions as a kind of Sigma type for categories. So just |
open DisplayedPoset | ||
|
||
-- The first projection is faithful in the case of a displayed poset | ||
FstIsForgetful : (D : DisplayedPoset {_} {_} {ℓP} C) → |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the naming convention is to call this isFaithfulFst
Fix the naming and merge this? |
Sorry, this slipped my mind while distracted by subobjects/pullbacks After wrestling with some merge conflicts, this is now mergeable. This tests are failing, but not because of this code. Upstream cubical has deprecated Because the tests aren't blocked on this piece of code, I will merge it and then open an issue for handling the change in cubical. sound reasonable? |
Sounds good. I'm aware of the change in cubical. It should just be a minor change for us |
Here is the forgetful functor from Grothendieck D to the category C, and a proof that this is faithful in the case that D is a displayed poset.