Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/improve pre commit #94

Merged
merged 3 commits into from
May 29, 2024
Merged

Chore/improve pre commit #94

merged 3 commits into from
May 29, 2024

Conversation

mauvehed
Copy link
Owner

docs(README.md): remove extra space in paragraph for better readability
style(index.html): add newline at end of file to adhere to best practices
style(CODE_OF_CONDUCT.md): remove unnecessary leading spaces for better readability
docs(CONTRIBUTING.md): remove unnecessary blank lines for cleaner code

The changes were made to improve the readability and cleanliness of the code and documentation. The extra space in the README.md file was removed to enhance readability. A newline was added at the end of the index.html file to adhere to best practices. Unnecessary leading spaces were removed from the CODE_OF_CONDUCT.md file for better readability. Lastly, unnecessary blank lines were removed from the CONTRIBUTING.md file to make the code cleaner.

feat: add pre-commit configuration file

A pre-commit configuration file has been added to the project to automate the process of checking for common issues before commits. This includes checks for trailing whitespace, file formatting, and preventing commits to the main branch. It also includes checks for potential security leaks using Gitleaks and code formatting using Prettier. This will help maintain code quality and prevent potential issues from being committed to the repository.

A pre-commit configuration file has been added to the project to automate the process of checking for common issues before commits. This includes checks for trailing whitespace, file formatting, and preventing commits to the main branch. It also includes checks for potential security leaks using Gitleaks and code formatting using Prettier. This will help maintain code quality and prevent potential issues from being committed to the repository.
style(index.html): add newline at end of file to adhere to best practices
style(CODE_OF_CONDUCT.md): remove unnecessary leading spaces for better readability
docs(CONTRIBUTING.md): remove unnecessary blank lines for cleaner code
The changes were made to improve the readability and cleanliness of the code and documentation. The extra space in the README.md file was removed to enhance readability. A newline was added at the end of the index.html file to adhere to best practices. Unnecessary leading spaces were removed from the CODE_OF_CONDUCT.md file for better readability. Lastly, unnecessary blank lines were removed from the CONTRIBUTING.md file to make the code cleaner.
@mauvehed mauvehed added the refactor Update the code with easier to understand or more efficient syntax or methods, but no new features. label May 29, 2024
@mauvehed mauvehed self-assigned this May 29, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mauvehed - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

.pre-commit-config.yaml Show resolved Hide resolved
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@mauvehed mauvehed merged commit aacc2c3 into main May 29, 2024
10 checks passed
@mauvehed mauvehed deleted the chore/improve-pre-commit branch May 29, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Update the code with easier to understand or more efficient syntax or methods, but no new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant