Fix reconnect loop #115
Merged
Fix reconnect loop #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkhsjdhjs
force-pushed
the
fix/reconnect_loop
branch
from
645e4ff
to
fe0d2fe
Compare
tadzik
reviewed
Aug 1, 2024
The 'close' listener is called when the socket is destroyed, which initiates another reconnect attempt. This reconnect attempt disconnects the new connection created by this control flow after the `retryDelay`. To avoid an endless reconnect loop, we need to remove the 'close' listener here before destroying the socket. Fix matrix-org#96
Signed-off-by: jkhsjdhjs <leon.moeller@yahoo.de>
jkhsjdhjs
force-pushed
the
fix/reconnect_loop
branch
from
16ca6f2
to
5377bd5
Compare
|
I guess it can't hurt and it also makes the code a bit prettier, as we can move the unbinding of the listeners to a separate function. Did so in 5377bd5 |
|
Perfect. Sorry for having this sit for long – thanks for the ping! |
tadzik
approved these changes
Sep 13, 2024
|
Github checks look stuck, but it's all good for me locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
closelistener is called when the socket is destroyed, which initiates another reconnect attempt. This reconnect attempt disconnects the new connection created by this control flow after theretryDelay. To avoid an endless reconnect loop, we need to remove thecloselistener here before destroying the socket.Fix #96