test: Bye bye SS proxy, hello Synapse \o/ #3983
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
requested review from
jmartinesp and
poljar
and removed request for
a team
|
🧀 I've updated the CI scripts. |
bnjbvr
requested changes
Sep 11, 2024
There was a problem hiding this comment.
me: ohnoes, i lost a piece of cheese because the tests passed???!
also me: always be doubting 👀 let's check the CI run
finally me: mwahahahah
bnjbvr
reviewed
Sep 11, 2024
bnjbvr
reviewed
Sep 11, 2024
.github/workflows/coverage.yml
Outdated
| # tests need a synapse: this is a service and not michaelkaye/setup-matrix-synapse@main as the | ||
| # latter does not provide networking for services to communicate with it. | ||
| synapse: | ||
| image: ghcr.io/matrix-org/synapse-service:5b6a75935e560945f69af72e9768bbaac10c9b4f # keep in sync with ./ci.yml | ||
| image: ghcr.io/matrix-org/synapse-service::v1.114.0 # keep in sync with ./ci.yml |
There was a problem hiding this comment.
Suggested change
| image: ghcr.io/matrix-org/synapse-service::v1.114.0 # keep in sync with ./ci.yml | |
| image: ghcr.io/matrix-org/synapse-service:v1.114.0 # keep in sync with ./ci.yml |
There was a problem hiding this comment.
On purpose. Because I want you to taste my local cheese.
This patch removes the sliding sync proxy, and makes the `matrix-sdk-integration-testing` tests to run against Synapse with MSC4186 enabled.
also why do people create manual fixup! commits?
bnjbvr
force-pushed
the
test-integration-bye-bye-ss-proxy
branch
from
5cfada1
to
9bb0d6d
Compare
Hywan
commented
Sep 16, 2024
| @@ -59,6 +59,7 @@ rc_invites: | |||
|
|
|||
| experimental_features: | |||
| msc3266_enabled: true | |||
| msc3575_enabled: true | |||
There was a problem hiding this comment.
We can remove that. It's true by default in Synapse.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3983 +/- ##
==========================================
+ Coverage 84.27% 84.30% +0.02%
==========================================
Files 266 266
Lines 28315 28306 -9
==========================================
- Hits 23863 23862 -1
+ Misses 4452 4444 -8 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the sliding sync proxy, and makes the
matrix-sdk-integration-testingtests to run against Synapse with MSC4186 enabled.