Docstrings for Source classes and other things #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
=======================================
Coverage 92.73% 92.73%
=======================================
Files 23 23
Lines 2052 2052
Branches 435 435
=======================================
Hits 1903 1903
Misses 97 97
Partials 52 52
☔ View full report in Codecov by Sentry. |
|
More mysterious test time-outs which I'm pretty sure have nothing to do with this docstring change. BTW I am happy to remove the warning about |
handrews
force-pushed
the
catalog-docstrings
branch
from
90fe35f
to
8e553cf
Compare
handrews
force-pushed
the
catalog-docstrings
branch
from
8e553cf
to
48e1d73
Compare
Add docstrings for Source, LocalSource, and RemoteSource. Also note the automatic use of the default catalog in the docstring for create_catalog(), so that it is clear that there is no need to do anything with its return value when no name is provided.
handrews
force-pushed
the
catalog-docstrings
branch
from
48e1d73
to
ab3e1ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add docstrings for Source, LocalSource, and RemoteSource.
Also note the automatic use of the default catalog in the docstring for create_catalog(), so that it is clear that there is no need to do anything with its return value when no name is provided.
First half of the replacement for #79, which I know was not slated for 0.10.1