Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

While updating tests found some dead code #77

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

marcpage
Copy link
Owner

There was some code that was not being executed during tests. Found out it could never be called. Refactored to do what was intended and updated tests to test the new code.

@marcpage marcpage added this to the Basic Functionality Match milestone Aug 28, 2024
@marcpage marcpage requested a review from pagerk August 28, 2024 10:54
@marcpage marcpage self-assigned this Aug 28, 2024
@pagerk pagerk merged commit 4bed5e6 into main Aug 28, 2024
6 checks passed
@pagerk pagerk deleted the users/marcp/dead-code branch August 28, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants