KeePassXC: Fix by setting deployment target for darwin 24. #25836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markemer
reviewed
Sep 19, 2024
| @@ -28,6 +28,10 @@ long_description KeePassXC is a community fork of KeePassX with the \ | |||
| license {GPL-2 GPL-3} | |||
| license_noconflict openssl openssl10 openssl11 openssl3 | |||
|
|
|||
| if { ${os.platform} eq "darwin" && ${os.major} >= 24 } { | |||
There was a problem hiding this comment.
I know my qt5 fix was bad but:
platform darwin 24 {
macosx_deployment_target 14.0
}
doesn't work?
P.S. - qt5 should be fixed now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
KeePassXC fails to compile on macOS 15/Xcode 16. Setting the macOS deployment target to 14 (or less) resolves the issue. See also:
https://trac.macports.org/wiki/SequoiaProblems#ScreenCaptureKitRequirementwithmacOS15SDK
NB: KeePassXC depends on ports qt5-qtbase and libsodium, which must be patched as well on macOS 15. qt5-qtbase can be patched in the same manner as this PR. libsodium just needs to be updated - see PR #25833.
Type(s)
Tested on
macOS 15.0 24A335 arm64
Xcode 16.0 16A242d / Command Line Tools 16.0.0.0.1.1724870825
Verification
Have you
port lint --nitpick?sudo port test?sudo port -vs install?