a2ps: fix build with Xcode gcc

[barracuda156]

Description

Fix build with old gcc

Type(s)

• bugfix
• enhancement
• security fix

Tested on

macOS 10.6
Xcode 3.2

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• referenced existing tickets on Trac with full URL in commit message?
• checked your Portfile with port lint --nitpick?
• tried existing tests with sudo port test?
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?
• checked that the Portfile's most important variants haven't been broken?

[reneeotten]

why not just select a compiler that understands this. Nobody wants s to keep on updating patches like this... and even if you would I am pretty sure MacPorts doesn't want to carry those forward indefinitely.

[barracuda156]

why not just select a compiler that understands this. Nobody wants s to keep on updating patches like this... and even if you would I am pretty sure MacPorts doesn't want to carry those forward indefinitely.

I believe @kencu and maybe @ryandesign were in favor of patches in similar cases, unless those get ridiculous. I am fine with either choice personally.

[ryandesign]

I agree that we are not the developers of a2ps and don't want to carry around patches forever. We prefer patches that can be sent upstream for inclusion in the next release. This patch is unsuitable for that since it just removes pragmas that they presumably want to use. If upstream development has ceased then it doesn't matter and we can patch whatever we want. I have indeed at times argued in favor of patching to appease older compilers, rather than declare older compilers incompatible, because compiling new compilers can be painfully slow on old computers.

[barracuda156]

I agree that we are not the developers of a2ps and don't want to carry around patches forever. We prefer patches that can be sent upstream for inclusion in the next release. This patch is unsuitable for that since it just removes pragmas that they presumably want to use. If upstream development has ceased then it doesn't matter and we can patch whatever we want. I have indeed at times argued in favor of patching to appease older compilers, rather than declare older compilers incompatible, because compiling new compilers can be painfully slow on old computers.

@ryandesign So should I switch this to compiler.blacklist here? I am fine with that.