Adds a new "foundations" module (#71)

* Adds a new "common" submodule for generic resources

We currently have submodules specific to certain related infrastructure in GCP
(e.g., platform-cluster, data-pipeline). There are quite a lot of resources in
GCP that do not fall neatly into one piece of infrastructure, or that may be
used by multiple things. This "common" submodule is a place to defined such
resources.

* Adds new common module to mlab-staging and mlab-oti projects

* Renames module "common" to "foundations"

"common" is too generic a word and maybe too broad, and possibly a reserved
sort of word in some contexts.

mlab-oti/foundations.tf

@@ -0,0 +1,8 @@
+module "foundations" {
+  source = "../modules/foundations"
+
+  providers = {
+    google = google.foundations
+  }
+}
+

mlab-oti/main.tf

@@ -30,3 +30,11 @@ provider "google" {
   region  = "us-central1"
   zone    = "us-central1-a"
 }
+
+provider "google" {
+  alias   = "foundations"
+  project = "mlab-oti"
+  region  = "us-central1"
+  zone    = "us-central1-a"
+}
+

mlab-sandbox/foundations.tf

@@ -0,0 +1,8 @@
+module "foundations" {
+  source = "../modules/foundations"
+
+  providers = {
+    google = google.foundations
+  }
+}
+

mlab-sandbox/main.tf

@@ -30,3 +30,10 @@ provider "google" {
   region  = "us-central1"
   zone    = "us-central1-a"
 }
+
+provider "google" {
+  alias   = "foundations"
+  project = "mlab-sandbox"
+  region  = "us-central1"
+  zone    = "us-central1-a"
+}

mlab-staging/foundations.tf

@@ -0,0 +1,8 @@
+module "foundations" {
+  source = "../modules/foundations"
+
+  providers = {
+    google = google.foundations
+  }
+}
+

mlab-staging/main.tf

@@ -31,3 +31,10 @@ provider "google" {
   zone    = "us-central1-a"
 }
 
+provider "google" {
+  alias   = "foundations"
+  project = "mlab-staging"
+  region  = "us-central1"
+  zone    = "us-central1-a"
+}
+

modules/README.md

@@ -0,0 +1,33 @@
+# Submodules
+
+This directory contains Terraform sub- or child-modules that can be included as
+necessary in any of the project root modules. This allows us the flexibility of
+including, or not, any module in any project, as needed.
+
+A modules in this directory should be named after a logically grouped set of
+infrastruture that it implement.
+
+## Module list
+
+### data-pipeline
+
+data-pipeline implements infrastructure associated with the ETL pipeline.
+
+### foundations
+
+foundations implements instrastructure that doesn't neatly fit into any other
+logical grouping of resources, or that may be used by more than one logical
+resource group. For example, defining the IAM bindings for the default Cloud
+Build service account, which may perform builds related to any or all logical
+resource groups, or which may perform builds not relevant to any particular
+resource group.
+
+### platform-cluster
+
+platform-cluster implements infrastructure associated with M-Lab's primary
+platform kubernetes cluster (i.e., where all experiments run).
+
+### visualizations
+
+visualizations implements infrastructure related to visualizations of the M-Lab
+data. These visualizations may or may not be public resources.

modules/foundations/artifactregistry.tf

@@ -0,0 +1,13 @@
+resource "google_artifact_registry_repository" "build_images" {
+  location      = "us-central1"
+  repository_id = "build-images"
+  description   = "Cloud Build container images"
+  format        = "DOCKER"
+}
+
+resource "google_artifact_registry_repository_iam_member" "member" {
+  location   = google_artifact_registry_repository.build_images.location
+  repository = google_artifact_registry_repository.build_images.name
+  role       = "roles/artifactregistry.reader"
+  member     = "allUsers"
+}

modules/foundations/main.tf

@@ -0,0 +1,8 @@
+terraform {
+  required_providers {
+    google = {
+      source = "hashicorp/google"
+    }
+  }
+}
+

versions.tf

@@ -5,6 +5,7 @@ terraform {
       version = "5.12.0"
       configuration_aliases = [
         google.data-pipeline,
+        google.foundations,
         google.platform-cluster,
         google.visualizations
       ]