Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add summary at the end of the measurement and fix RTT calc #45

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

robertodauria
Copy link
Contributor

@robertodauria robertodauria commented Feb 6, 2024

This PR adds a summary at the end of the measurement and fixes the RTT calculations.

Closes #40


This change is Reviewable

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7798937328

  • -55 of 57 (3.51%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-1.2%) to 68.291%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/client/emitter.go 0 12 0.0%
pkg/client/client.go 2 45 4.44%
Files with Coverage Reduction New Missed Lines %
pkg/client/emitter.go 1 0.0%
Totals Coverage Status
Change from base Build 7626914882: -1.2%
Covered Lines: 883
Relevant Lines: 1293

💛 - Coveralls

Copy link
Contributor

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @robertodauria)


pkg/client/client.go line 100 at r1 (raw file):

	// minRTT is the lowest RTT value observed across all streams.
	minRTT atomic.Uint32

I'm wondering out loud if there's a way to combine the measures for a synthetic measurement (e.g. just avg, or min/avg/max like ping) without dropping some data.

@robertodauria robertodauria merged commit c3544e4 into main Feb 7, 2024
7 checks passed
@robertodauria robertodauria deleted the summary branch February 7, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add summary at the end of a measurement
3 participants